Use power operator instead of math.pow (#1210)

Perryvw · web-flow · commit 7abca43f0c23 · 2022-01-14T10:22:59.000+01:00
* Use power operator instead of math.pow in lua 5.3 and later

* Always use ^ instead of math.pow
diff --git a/src/transformation/builtins/math.ts b/src/transformation/builtins/math.ts
@@ -70,6 +70,11 @@ export function transformMathCall(
             return lua.createCallExpression(lua.createTableIndexExpression(math, log), [add], node);
         }
 
+        case "pow": {
+            // Translate to base ^ power
+            return lua.createBinaryExpression(params[0], params[1], lua.SyntaxKind.PowerOperator, node);
+        }
+
         // math.floor(x + 0.5)
         case "round": {
             const floor = lua.createStringLiteral("floor");
@@ -93,7 +98,6 @@ export function transformMathCall(
         case "log":
         case "max":
         case "min":
-        case "pow":
         case "random":
         case "sin":
         case "sqrt":
diff --git a/test/unit/builtins/math.spec.ts b/test/unit/builtins/math.spec.ts
@@ -84,11 +84,14 @@ util.testEachVersion("Math.atan2", () => util.testExpression`Math.atan2(4, 5)`,
     [tstl.LuaTarget.Lua54]: builder => builder.tap(expectMathAtan2),
 });
 
-util.testEachVersion("Math.atan2(4, 5)", () => util.testExpression`Math.atan2(4, 5)`, {
-    [tstl.LuaTarget.Universal]: builder => builder.expectToMatchJsResult(),
-    [tstl.LuaTarget.LuaJIT]: false,
-    [tstl.LuaTarget.Lua51]: builder => builder.expectToMatchJsResult(),
-    [tstl.LuaTarget.Lua52]: builder => builder.expectToMatchJsResult(),
-    [tstl.LuaTarget.Lua53]: builder => builder.expectToMatchJsResult(),
-    [tstl.LuaTarget.Lua54]: builder => builder.expectToMatchJsResult(),
-});
+util.testEachVersion(
+    "Math.atan2(4, 5)",
+    () => util.testExpression`Math.atan2(4, 5)`,
+    util.expectEachVersionExceptJit(builder => builder.expectToMatchJsResult())
+);
+
+util.testEachVersion(
+    "Math.pow(3, 5)",
+    () => util.testExpression`Math.pow(3, 5)`,
+    util.expectEachVersionExceptJit(builder => builder.expectToMatchJsResult())
+);
