5.0: Emulate % with native math.mod() (#1370)

YoRyan · web-flow · commit 74a404a1dcad · 2022-11-28T21:08:54.000+01:00
* refactor(5.0): emulate modulo with native math.mod()

* refactor(5.0): remove the modulo lualib feature altogether
diff --git a/src/LuaLib.ts b/src/LuaLib.ts
@@ -52,7 +52,6 @@ export enum LuaLibFeature {
     MathAtan2 = "MathAtan2",
     MathModf = "MathModf",
     MathSign = "MathSign",
-    Modulo50 = "Modulo50",
     New = "New",
     Number = "Number",
     NumberIsFinite = "NumberIsFinite",
diff --git a/src/lualib/Modulo50.ts b/src/lualib/Modulo50.ts
diff --git a/src/transformation/visitors/binary-expression/index.ts b/src/transformation/visitors/binary-expression/index.ts
@@ -70,7 +70,8 @@ function transformBinaryOperationWithNoPrecedingStatements(
     }
 
     if (operator === ts.SyntaxKind.PercentToken && context.luaTarget === LuaTarget.Lua50) {
-        return transformLuaLibFunction(context, LuaLibFeature.Modulo50, node, left, right);
+        const mathMod = lua.createTableIndexExpression(lua.createIdentifier("math"), lua.createStringLiteral("mod"));
+        return lua.createCallExpression(mathMod, [left, right], node);
     }
 
     let luaOperator = simpleOperatorsToLua[operator];

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,8 @@ function transformBinaryOperationWithNoPrecedingStatements(`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`if (operator === ts.SyntaxKind.PercentToken && context.luaTarget === LuaTarget.Lua50) {`
`73`		`- return transformLuaLibFunction(context, LuaLibFeature.Modulo50, node, left, right);`
	`73`	`+ const mathMod = lua.createTableIndexExpression(lua.createIdentifier("math"), lua.createStringLiteral("mod"));`
	`74`	`+ return lua.createCallExpression(mathMod, [left, right], node);`
`74`	`75`	`}`
`75`	`76`
`76`	`77`	`let luaOperator = simpleOperatorsToLua[operator];`