Fixed StringReplace and StringSplit

Perryvw · Perryvw · commit 64cbbe8558dd · 2018-07-20T14:26:21.000+02:00
diff --git a/src/lualib/StringReplace.ts b/src/lualib/StringReplace.ts
@@ -1,7 +1,8 @@
 declare namespace string {
-    function gsub(source: string, searchValue: string, replaceValue: string): string;
+    /** !TupleReturn */
+    function gsub(source: string, searchValue: string, replaceValue: string): [string, number];
 }
 
 function __TS__StringReplace(source: string, searchValue: string, replaceValue: string): string {
-    return string.gsub(source, searchValue, replaceValue);
+    return string.gsub(source, searchValue, replaceValue)[0];
 }
diff --git a/src/lualib/StringSplit.ts b/src/lualib/StringSplit.ts
@@ -0,0 +1,36 @@
+function __TS__StringSplit(source: string, separator?: string, limit?: number): string[] {
+    if (limit === undefined) {
+        limit = 4294967295;
+    }
+
+    if (limit === 0) {
+        return [];
+    }
+
+    const out = [];
+    let index = 0;
+    let count = 0;
+
+    if (separator === undefined || separator === "") {
+        while (index < source.length - 1 && count < limit) {
+            out[count] = source[index];
+            count++;
+            index++;
+        }
+    } else {
+        const separatorLength = separator.length;
+        let nextIndex = source.indexOf(separator);
+        while (nextIndex >= 0 && count < limit) {
+            out[count] = source.substring(index, nextIndex);
+            count++;
+            index = nextIndex + separatorLength;
+            nextIndex = source.indexOf(separator, index);
+        }
+    }
+
+    if (count < limit) {
+        out[count] = source.substring(index);
+    }
+
+    return out;
+}

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,8 @@`
`1`	`1`	`declare namespace string {`
`2`		`- function gsub(source: string, searchValue: string, replaceValue: string): string;`
	`2`	`+ /** !TupleReturn */`
	`3`	`+ function gsub(source: string, searchValue: string, replaceValue: string): [string, number];`
`3`	`4`	`}`
`4`	`5`
`5`	`6`	`function __TS__StringReplace(source: string, searchValue: string, replaceValue: string): string {`
`6`		`- return string.gsub(source, searchValue, replaceValue);`
	`7`	`+ return string.gsub(source, searchValue, replaceValue)[0];`
`7`	`8`	`}`