Fixed some linting issues

Perryvw · Perryvw · commit 5f72d435416e · 2018-07-22T13:59:32.000+02:00
diff --git a/src/CommandLineParser.ts b/src/CommandLineParser.ts
@@ -102,7 +102,7 @@ export function parseCommandLine(args: string[]): ParsedCommandLine {
 
 function addTSTLOptions(commandLine: ts.ParsedCommandLine,
                         additionalArgs?: yargs.Arguments,
-                        forceOverride?: boolean) {
+                        forceOverride?: boolean): void {
     additionalArgs = additionalArgs ? additionalArgs : commandLine.raw;
     // Add compiler options that are ignored by TS parsers
     if (additionalArgs) {
@@ -116,7 +116,7 @@ function addTSTLOptions(commandLine: ts.ParsedCommandLine,
 }
 
 /** Check the current state of the ParsedCommandLine for errors */
-function runDiagnostics(commandLine: ts.ParsedCommandLine) {
+function runDiagnostics(commandLine: ts.ParsedCommandLine): void {
     // Remove files that dont exist
     commandLine.fileNames = commandLine.fileNames.filter(file => fs.existsSync(file) || fs.existsSync(file + ".ts"));
 
@@ -154,7 +154,7 @@ function runDiagnostics(commandLine: ts.ParsedCommandLine) {
 }
 
 /** Find configFile, function from ts api seems to be broken? */
-export function findConfigFile(commandLine: ts.ParsedCommandLine) {
+export function findConfigFile(commandLine: ts.ParsedCommandLine): void {
     if (!commandLine.options.project) {
         throw new CLIError(`error no base path provided, could not find config.`);
     }
diff --git a/src/Compiler.ts b/src/Compiler.ts
@@ -9,7 +9,7 @@ import { LuaTranspiler53 } from "./targets/Transpiler.53";
 import { LuaTranspilerJIT } from "./targets/Transpiler.JIT";
 import { LuaLibImportKind, LuaTarget, LuaTranspiler, TranspileError } from "./Transpiler";
 
-export function compile(argv: string[]) {
+export function compile(argv: string[]): void {
     const commandLine = parseCommandLine(argv);
     compileFilesWithOptions(commandLine.fileNames, commandLine.options);
 }
diff --git a/src/TSHelper.ts b/src/TSHelper.ts
@@ -3,7 +3,7 @@ import * as ts from "typescript";
 export class TSHelper {
 
     // Reverse lookup of enum key by value
-    public static enumName(needle, haystack) {
+    public static enumName(needle, haystack): string {
         for (const name in haystack) {
             if (haystack[name] === needle) {
                 return name;
@@ -13,7 +13,7 @@ export class TSHelper {
     }
 
     // Breaks down a mask into all flag names.
-    public static enumNames(mask, haystack) {
+    public static enumNames(mask, haystack): string[] {
         const result = [];
         for (const name in haystack) {
             if ((mask & haystack[name]) !== 0 && mask >= haystack[name]) {
@@ -41,7 +41,7 @@ export class TSHelper {
         return undefined;
     }
 
-    public static isFileModule(sourceFile: ts.SourceFile) {
+    public static isFileModule(sourceFile: ts.SourceFile): boolean {
         if (sourceFile) {
             // Vanilla ts flags files as external module if they have an import or
             // export statement, we only check for export statements
@@ -53,7 +53,7 @@ export class TSHelper {
         return false;
     }
 
-    public static isInDestructingAssignment(node: ts.Node) {
+    public static isInDestructingAssignment(node: ts.Node): boolean {
         return node.parent && ts.isVariableDeclaration(node.parent) && ts.isArrayBindingPattern(node.parent.name);
     }
 
diff --git a/src/Transpiler.ts b/src/Transpiler.ts
@@ -1259,6 +1259,8 @@ export abstract class LuaTranspiler {
             return "__";
         } else if (ts.isIdentifier(name)) {
             return this.transpileIdentifier(name);
+        } else if (ts.isBindingElement(name) && ts.isIdentifier(name.name)) {
+            return this.transpileIdentifier(name.name);
         } else {
             const kind = tsHelper.enumName(name.kind, ts.SyntaxKind);
             throw new TranspileError(`Encountered not-supported array binding element kind: ${kind}`, name);
@@ -1303,7 +1305,7 @@ export abstract class LuaTranspiler {
                 throw new TranspileError(`Ellipsis destruction is not allowed.`, node);
             }
 
-            const vars = node.name.elements.map(this.transpileArrayBindingElement).join(",");
+            const vars = node.name.elements.map(e => this.transpileArrayBindingElement(e)).join(",");
 
             // Don't unpack TupleReturn decorated functions
             if (tsHelper.isTupleReturnCall(node.initializer, this.checker)) {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ import { LuaTranspiler53 } from "./targets/Transpiler.53";`
`9`	`9`	`import { LuaTranspilerJIT } from "./targets/Transpiler.JIT";`
`10`	`10`	`import { LuaLibImportKind, LuaTarget, LuaTranspiler, TranspileError } from "./Transpiler";`
`11`	`11`
`12`		`-export function compile(argv: string[]) {`
	`12`	`+export function compile(argv: string[]): void {`
`13`	`13`	`const commandLine = parseCommandLine(argv);`
`14`	`14`	`compileFilesWithOptions(commandLine.fileNames, commandLine.options);`
`15`	`15`	`}`