Remove unnecessary luaTable set expression check and specific exception

hazzard993 · hazzard993 · commit 4a0f0229f292 · 2019-08-19T11:02:01.000+10:00
diff --git a/src/LuaTransformer.ts b/src/LuaTransformer.ts
@@ -4996,9 +4996,6 @@ export class LuaTransformer {
                 if (callArguments.length !== 2) {
                     throw TSTLErrors.ForbiddenLuaTableUseException("Two parameters are required for set().", original);
                 }
-                if (original.parent.kind !== ts.SyntaxKind.ExpressionStatement) {
-                    throw TSTLErrors.ForbiddenLuaTableSetExpression(original);
-                }
                 break;
         }
     }
diff --git a/src/TSTLErrors.ts b/src/TSTLErrors.ts
@@ -13,12 +13,6 @@ export const ForbiddenEllipsisDestruction = (node: ts.Node) =>
 export const ForbiddenForIn = (node: ts.Node) =>
     new TranspileError(`Iterating over arrays with 'for ... in' is not allowed.`, node);
 
-export const ForbiddenLuaTableSetExpression = (node: ts.Node) =>
-    new TranspileError(
-        `A '@luaTable' object's 'set()' method can only be used as a Statement, not an Expression.`,
-        node
-    );
-
 export const ForbiddenLuaTableNonDeclaration = (node: ts.Node) =>
     new TranspileError(`Classes with the '@luaTable' decorator must be declared.`, node);
 
diff --git a/test/unit/decorators/luaTable.spec.ts b/test/unit/decorators/luaTable.spec.ts
@@ -35,11 +35,14 @@ test.each([tableLibClass])("LuaTables cannot be constructed with arguments", tab
     );
 });
 
-test.each([tableLibClass, tableLibInterface])("LuaTable set() cannot be used in an expression position", tableLib => {
-    expect(() => util.transpileString(tableLib + `const exp = tbl.set("value", 5)`)).toThrowExactError(
-        TSTLErrors.ForbiddenLuaTableSetExpression(util.nodeStub)
-    );
-});
+test.each([tableLibClass, tableLibInterface])(
+    "LuaTable set() cannot be used in a LuaTable call expression",
+    tableLib => {
+        expect(() => util.transpileString(tableLib + `const exp = tbl.set("value", 5)`)).toThrowExactError(
+            TSTLErrors.UnsupportedProperty("LuaTable", "set", util.nodeStub)
+        );
+    }
+);
 
 test.each([tableLibClass, tableLibInterface])("LuaTables cannot have other members", tableLib => {
     expect(() => util.transpileString(tableLib + `tbl.other()`)).toThrowExactError(

Original file line number	Diff line number	Diff line change
`@@ -4996,9 +4996,6 @@ export class LuaTransformer {`
`4996`	`4996`	`if (callArguments.length !== 2) {`
`4997`	`4997`	`throw TSTLErrors.ForbiddenLuaTableUseException("Two parameters are required for set().", original);`
`4998`	`4998`	`}`
`4999`		`- if (original.parent.kind !== ts.SyntaxKind.ExpressionStatement) {`
`5000`		`- throw TSTLErrors.ForbiddenLuaTableSetExpression(original);`
`5001`		`- }`
`5002`	`4999`	`break;`
`5003`	`5000`	`}`
`5004`	`5001`	`}`