fix module-resolution tests

Perryvw · Perryvw · commit 486474ff24b2 · 2026-04-01T21:57:34.000+02:00
diff --git a/src/CompilerOptions.ts b/src/CompilerOptions.ts
@@ -99,9 +99,5 @@ export function validateOptions(options: CompilerOptions): ts.Diagnostic[] {
         diagnostics.push(diagnosticFactories.unsupportedJsxEmit());
     }
 
-    if (options.paths && !options.baseUrl) {
-        diagnostics.push(diagnosticFactories.pathsWithoutBaseUrl());
-    }
-
     return diagnostics;
 }
diff --git a/src/transpilation/diagnostics.ts b/src/transpilation/diagnostics.ts
@@ -55,7 +55,3 @@ export const cannotBundleLibrary = createDiagnosticFactory(
 );
 
 export const unsupportedJsxEmit = createDiagnosticFactory(() => 'JSX is only supported with "react" jsx option.');
-
-export const pathsWithoutBaseUrl = createDiagnosticFactory(
-    () => "When configuring 'paths' in tsconfig.json, the option 'baseUrl' must also be provided."
-);
diff --git a/src/transpilation/resolve.ts b/src/transpilation/resolve.ts
@@ -222,11 +222,7 @@ class ResolutionContext {
                 this.options.baseUrl ??
                 (this.options.configFilePath ? path.dirname(this.options.configFilePath) : undefined);
             if (pathsBase) {
-                const fileFromPaths = this.tryGetModuleNameFromPaths(
-                    dependencyPath,
-                    this.options.paths,
-                    pathsBase
-                );
+                const fileFromPaths = this.tryGetModuleNameFromPaths(dependencyPath, this.options.paths, pathsBase);
                 if (fileFromPaths) return fileFromPaths;
             }
         }
diff --git a/test/transpile/__snapshots__/module-resolution.spec.ts.snap b/test/transpile/__snapshots__/module-resolution.spec.ts.snap
@@ -10,8 +10,8 @@ exports[`supports complicated paths configuration 1`] = `
 
 exports[`supports paths configuration 1`] = `
 [
-  "/paths-simple/myprogram/dist/main.lua",
   "/paths-simple/myprogram/dist/mypackage/bar.lua",
   "/paths-simple/myprogram/dist/mypackage/index.lua",
+  "/paths-simple/myprogram/dist/myprogram/main.lua",
 ]
 `;
diff --git a/test/transpile/module-resolution.spec.ts b/test/transpile/module-resolution.spec.ts
@@ -4,7 +4,6 @@ import * as util from "../util";
 import * as ts from "typescript";
 import { BuildMode } from "../../src";
 import { normalizeSlashes } from "../../src/utils";
-import { pathsWithoutBaseUrl } from "../../src/transpilation/diagnostics";
 
 describe("basic module resolution", () => {
     const projectPath = path.resolve(__dirname, "module-resolution", "project-with-node-modules");
@@ -457,6 +456,7 @@ describe("module resolution should not try to resolve modules in noResolvePaths"
 
             export const result = b.foo();
         `
+            .addExtraFile("preload.d.ts", `declare module "preload" {}`)
             .addExtraFile("preload.lua", 'package.preload["ignoreme"] = function() return nil end')
             .addExtraFile(
                 "actualfile.ts",
@@ -598,7 +598,7 @@ test("module resolution uses baseURL to resolve imported files", () => {
                 return { baz = function() return "baz" end }
             `
         )
-        .setOptions({ baseUrl: "./myproject/mydeps" })
+        .setOptions({ baseUrl: "./myproject/mydeps", ignoreDeprecations: "6.0" })
         .expectToEqual({
             fooResult: "foo",
             barResult: "bar",
@@ -707,10 +707,6 @@ test("supports complicated paths configuration", () => {
         .expectToEqual({ foo: 314, bar: 271 });
 });
 
-test("paths without baseUrl is error", () => {
-    util.testFunction``.setOptions({ paths: {} }).expectToHaveDiagnostics([pathsWithoutBaseUrl.code]);
-});
-
 test("module resolution using plugin", () => {
     const baseProjectPath = path.resolve(__dirname, "module-resolution", "project-with-module-resolution-plugin");
     const projectTsConfig = path.join(baseProjectPath, "tsconfig.json");
diff --git a/test/transpile/module-resolution/paths-base-tsconfig/tsconfig.base.json b/test/transpile/module-resolution/paths-base-tsconfig/tsconfig.base.json
@@ -2,6 +2,7 @@
     "compilerOptions": {
         "rootDir": ".",
         "baseUrl": ".",
+        "ignoreDeprecations": "6.0",
         "paths": {
             "mypackage": ["packages/mypackage/src/index.ts"],
             "mypackage/*": ["packages/mypackage/src/*"]
diff --git a/test/transpile/module-resolution/paths-simple/myprogram/tsconfig.json b/test/transpile/module-resolution/paths-simple/myprogram/tsconfig.json
@@ -1,6 +1,6 @@
 {
     "compilerOptions": {
-        "baseUrl": ".",
+        "rootDir": "..",
         "outDir": "dist",
         "paths": {
             "myOtherPackage": ["../mypackage"],
diff --git a/test/transpile/module-resolution/project-with-node-modules/tsconfig.json b/test/transpile/module-resolution/project-with-node-modules/tsconfig.json
@@ -7,6 +7,7 @@
         "target": "esnext",
         "lib": ["esnext"],
         "types": [],
-        "rootDir": "."
+        "rootDir": ".",
+        "noUncheckedSideEffectImports": false
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,5 @@ export function validateOptions(options: CompilerOptions): ts.Diagnostic[] {`
`99`	`99`	`diagnostics.push(diagnosticFactories.unsupportedJsxEmit());`
`100`	`100`	`}`
`101`	`101`
`102`		`- if (options.paths && !options.baseUrl) {`
`103`		`- diagnostics.push(diagnosticFactories.pathsWithoutBaseUrl());`
`104`		`- }`
`105`		`-`
`106`	`102`	`return diagnostics;`
`107`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -222,11 +222,7 @@ class ResolutionContext {`
`222`	`222`	`this.options.baseUrl ??`
`223`	`223`	`(this.options.configFilePath ? path.dirname(this.options.configFilePath) : undefined);`
`224`	`224`	`if (pathsBase) {`
`225`		`- const fileFromPaths = this.tryGetModuleNameFromPaths(`
`226`		`- dependencyPath,`
`227`		`- this.options.paths,`
`228`		`- pathsBase`
`229`		`- );`
	`225`	`+ const fileFromPaths = this.tryGetModuleNameFromPaths(dependencyPath, this.options.paths, pathsBase);`
`230`	`226`	`if (fileFromPaths) return fileFromPaths;`
`231`	`227`	`}`
`232`	`228`	`}`
Original file line number	Diff line number	Diff line change
@@ -10,8 +10,8 @@ exports[`supports complicated paths configuration 1`] = `
`10`	`10`
`11`	`11`	exports[`supports paths configuration 1`] = `
`12`	`12`	`[`
`13`		`- "/paths-simple/myprogram/dist/main.lua",`
`14`	`13`	`"/paths-simple/myprogram/dist/mypackage/bar.lua",`
`15`	`14`	`"/paths-simple/myprogram/dist/mypackage/index.lua",`
	`15`	`+ "/paths-simple/myprogram/dist/myprogram/main.lua",`
`16`	`16`	`]`
`17`	`17`	`;
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`		`- "baseUrl": ".",`
	`3`	`+ "rootDir": "..",`
`4`	`4`	`"outDir": "dist",`
`5`	`5`	`"paths": {`
`6`	`6`	`"myOtherPackage": ["../mypackage"],`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`"target": "esnext",`
`8`	`8`	`"lib": ["esnext"],`
`9`	`9`	`"types": [],`
`10`		`- "rootDir": "."`
	`10`	`+ "rootDir": ".",`
	`11`	`+ "noUncheckedSideEffectImports": false`
`11`	`12`	`}`
`12`	`13`	`}`