Use TypeScript 3.4 readonly array literals syntax

ark120202 · ark120202 · commit 392caad0bd72 · 2019-05-06T15:54:29.000+05:00
diff --git a/src/LuaTransformer.ts b/src/LuaTransformer.ts
@@ -208,7 +208,7 @@ export class LuaTransformer {
     }
 
     /** Converts an array of ts.Statements into an array of tstl.Statements */
-    private transformStatements(statements: ts.Statement[] | ReadonlyArray<ts.Statement>): tstl.Statement[] {
+    private transformStatements(statements: readonly ts.Statement[]): tstl.Statement[] {
         const tstlStatements: tstl.Statement[] = [];
         (statements as ts.Statement[]).forEach(statement => {
             tstlStatements.push(...this.statementVisitResultToArray(this.transformStatement(statement)));
diff --git a/src/TSHelper.ts b/src/TSHelper.ts
@@ -470,15 +470,15 @@ export class TSHelper {
         return checker.getContextualType(expression) || checker.getTypeAtLocation(expression);
     }
 
-    public static getAllCallSignatures(type: ts.Type): ReadonlyArray<ts.Signature> {
+    public static getAllCallSignatures(type: ts.Type): readonly ts.Signature[] {
         if (type.isUnion()) {
             return type.types.map(t => TSHelper.getAllCallSignatures(t)).reduce((a, b) => a.concat(b));
         }
         return type.getCallSignatures();
     }
 
     public static getSignatureDeclarations(
-        signatures: ReadonlyArray<ts.Signature>,
+        signatures: readonly ts.Signature[],
         checker: ts.TypeChecker
     ): ts.SignatureDeclaration[]
     {
diff --git a/src/lualib/ArrayFlatMap.ts b/src/lualib/ArrayFlatMap.ts
@@ -1,7 +1,7 @@
 function __TS__ArrayFlatMap<T, U>(
     this: void,
     array: T[],
-    callback: (value: T, index: number, array: T[]) => U | ReadonlyArray<U>
+    callback: (value: T, index: number, array: T[]) => U | readonly U[]
 ): U[] {
     let result: U[] = [];
     for (let i = 0; i < array.length; i++) {
diff --git a/src/tstl.ts b/src/tstl.ts
@@ -134,9 +134,9 @@ function performBuild(_args: string[]): void {
 
 function performCompilation(
     rootNames: string[],
-    projectReferences: ReadonlyArray<ts.ProjectReference> | undefined,
+    projectReferences: readonly ts.ProjectReference[] | undefined,
     options: tstl.CompilerOptions,
-    configFileParsingDiagnostics?: ReadonlyArray<ts.Diagnostic>
+    configFileParsingDiagnostics?: readonly ts.Diagnostic[]
 ): void {
     const program = ts.createProgram({
         rootNames,
diff --git a/test/unit/array.spec.ts b/test/unit/array.spec.ts
@@ -10,7 +10,7 @@ test("Array access", () => {
 
 test("Readonly Array access", () => {
     const result = util.transpileAndExecute(
-        `const arr: ReadonlyArray<number> = [3,5,1];
+        `const arr: readonly number[] = [3,5,1];
         return arr[1];`,
     );
     expect(result).toBe(5);

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ export class LuaTransformer {`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`/** Converts an array of ts.Statements into an array of tstl.Statements */`
`211`		`- private transformStatements(statements: ts.Statement[] \| ReadonlyArray<ts.Statement>): tstl.Statement[] {`
	`211`	`+ private transformStatements(statements: readonly ts.Statement[]): tstl.Statement[] {`
`212`	`212`	`const tstlStatements: tstl.Statement[] = [];`
`213`	`213`	`(statements as ts.Statement[]).forEach(statement => {`
`214`	`214`	`tstlStatements.push(...this.statementVisitResultToArray(this.transformStatement(statement)));`
Original file line number	Diff line number	Diff line change
`@@ -470,15 +470,15 @@ export class TSHelper {`
`470`	`470`	`return checker.getContextualType(expression) \|\| checker.getTypeAtLocation(expression);`
`471`	`471`	`}`
`472`	`472`
`473`		`- public static getAllCallSignatures(type: ts.Type): ReadonlyArray<ts.Signature> {`
	`473`	`+ public static getAllCallSignatures(type: ts.Type): readonly ts.Signature[] {`
`474`	`474`	`if (type.isUnion()) {`
`475`	`475`	`return type.types.map(t => TSHelper.getAllCallSignatures(t)).reduce((a, b) => a.concat(b));`
`476`	`476`	`}`
`477`	`477`	`return type.getCallSignatures();`
`478`	`478`	`}`
`479`	`479`
`480`	`480`	`public static getSignatureDeclarations(`
`481`		`- signatures: ReadonlyArray<ts.Signature>,`
	`481`	`+ signatures: readonly ts.Signature[],`
`482`	`482`	`checker: ts.TypeChecker`
`483`	`483`	`): ts.SignatureDeclaration[]`
`484`	`484`	`{`