Added some more cli tests

lolleko · lolleko · commit 37b0b8cbd2bf · 2018-05-12T17:22:24.000+02:00
Added tests for some untested lines in cliparser
diff --git a/src/CommandLineParser.ts b/src/CommandLineParser.ts
@@ -118,20 +118,17 @@ function addTSTLOptions(commandLine: ts.ParsedCommandLine,
 /** Check the current state of the ParsedCommandLine for errors */
 function runDiagnostics(commandLine: ts.ParsedCommandLine) {
     const tsInvalidCompilerOptionErrorCode = 5023;
-
     if (commandLine.errors.length !== 0) {
         // Generate a list of valid option names and aliases
         const optionNames: string[] = [];
-        for (const key in optionDeclarations) {
-            if (optionDeclarations[key]) {
-                optionNames.push(key);
-                const alias = optionDeclarations[key].alias;
-                if (alias) {
-                    if (typeof alias === "string") {
-                        optionNames.push(alias);
-                    } else {
-                        optionNames.push(...alias);
-                    }
+        for (const key of Object.keys(optionDeclarations)) {
+            optionNames.push(key);
+            const alias = optionDeclarations[key].alias;
+            if (alias) {
+                if (typeof alias === "string") {
+                    optionNames.push(alias);
+                } else {
+                    optionNames.push(...alias);
                 }
             }
         }
diff --git a/test/unit/cli.spec.ts b/test/unit/cli.spec.ts
@@ -2,7 +2,6 @@ import { Expect, Test, TestCase, Teardown } from "alsatian";
 
 import { CompilerOptions, findConfigFile, parseCommandLine, ParsedCommandLine } from "../../src/CommandLineParser";
 
-
 export class CLITests {
 
     @Test("defaultOption")
@@ -17,6 +16,12 @@ export class CLITests {
         Expect(expected).toBe(parsedCommandLine.options[option]);
     }
 
+    @Test("ValidLuaTarget")
+    public validLuaTarget() {
+        let parsedCommandLine = parseCommandLine(['--luaTarget', '5.3']);
+        Expect(parsedCommandLine.options["luaTarget"]).toBe("5.3");
+    }
+
     @Test("InvalidLuaTarget")
     public invalidLuaTarget() {
         // Don't check error message because the yargs library messes the message up.
