Simplify expression + 1 for numeric literals

ark120202 · ark120202 · commit 260680927b09 · 2019-05-06T16:34:30.000+05:00
diff --git a/src/LuaTransformer.ts b/src/LuaTransformer.ts
@@ -5086,10 +5086,17 @@ export class LuaTransformer {
         return tstl.createCallExpression(tstl.createIdentifier("tostring"), [expression]);
     }
 
-    protected expressionPlusOne(expression: tstl.Expression): tstl.BinaryExpression {
+    protected expressionPlusOne(expression: tstl.Expression): tstl.Expression {
+        if (tstl.isNumericLiteral(expression)) {
+            const newNode = tstl.cloneNode(expression);
+            newNode.value += 1;
+            return newNode;
+        }
+
         if (tstl.isBinaryExpression(expression)) {
             expression = tstl.createParenthesizedExpression(expression);
         }
+
         return tstl.createBinaryExpression(expression, tstl.createNumericLiteral(1), tstl.SyntaxKind.AdditionOperator);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -5086,10 +5086,17 @@ export class LuaTransformer {`
`5086`	`5086`	`return tstl.createCallExpression(tstl.createIdentifier("tostring"), [expression]);`
`5087`	`5087`	`}`
`5088`	`5088`
`5089`		`- protected expressionPlusOne(expression: tstl.Expression): tstl.BinaryExpression {`
	`5089`	`+ protected expressionPlusOne(expression: tstl.Expression): tstl.Expression {`
	`5090`	`+ if (tstl.isNumericLiteral(expression)) {`
	`5091`	`+ const newNode = tstl.cloneNode(expression);`
	`5092`	`+ newNode.value += 1;`
	`5093`	`+ return newNode;`
	`5094`	`+ }`
	`5095`	`+`
`5090`	`5096`	`if (tstl.isBinaryExpression(expression)) {`
`5091`	`5097`	`expression = tstl.createParenthesizedExpression(expression);`
`5092`	`5098`	`}`
	`5099`	`+`
`5093`	`5100`	`return tstl.createBinaryExpression(expression, tstl.createNumericLiteral(1), tstl.SyntaxKind.AdditionOperator);`
`5094`	`5101`	`}`
`5095`	`5102`