using full form of 'super' call when base is an exported identfier (#637)

tomblind · Perryvw · commit 2535f39d319b · 2019-06-19T20:22:14.000+02:00
diff --git a/src/LuaTransformer.ts b/src/LuaTransformer.ts
@@ -3568,11 +3568,15 @@ export class LuaTransformer {
         }
 
         const extendsExpression = typeNode.expression;
-        let baseClassName: tstl.AssignmentLeftHandSideExpression;
+        let baseClassName: tstl.AssignmentLeftHandSideExpression | undefined;
         if (ts.isIdentifier(extendsExpression)) {
-            // Use "baseClassName" if base is a simple identifier
-            baseClassName = this.transformIdentifier(extendsExpression);
-        } else {
+            const symbol = this.checker.getSymbolAtLocation(extendsExpression);
+            if (symbol && !this.isSymbolExported(symbol)) {
+                // Use "baseClassName" if base is a simple identifier
+                baseClassName = this.transformIdentifier(extendsExpression);
+            }
+        }
+        if (!baseClassName) {
             if (classDeclaration.name === undefined) {
                 throw TSTLErrors.MissingClassName(expression);
             }
diff --git a/test/unit/class.spec.ts b/test/unit/class.spec.ts
@@ -198,6 +198,27 @@ test("SubclassConstructor", () => {
     expect(result).toBe(11);
 });
 
+test("Subclass constructor across merged namespace", () => {
+    const tsHeader = `
+        namespace NS {
+            export class Super {
+                prop: string;
+                constructor() {
+                    this.prop = "foo";
+                }
+            }
+        }
+        namespace NS {
+            export class Sub extends Super {
+                constructor() {
+                    super();
+                }
+            }
+        }`;
+
+    expect(util.transpileAndExecute("return (new NS.Sub()).prop", undefined, undefined, tsHeader)).toBe("foo");
+});
+
 test("classSuper", () => {
     const result = util.transpileAndExecute(
         `class a {
