clean up tests

Perryvw · Perryvw · commit 1dba0603831b · 2024-12-29T16:49:28.000+01:00
diff --git a/test/translation/__snapshots__/transformation.spec.ts.snap b/test/translation/__snapshots__/transformation.spec.ts.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Luau Transformation (luauSpecificTransformations) 1`] = `
+exports[`Luau-specific Transformation (luauSpecificTransformations) 1`] = `
 "t = if true then "is true" else "is false"
 while false do
     continue
diff --git a/test/translation/transformation.spec.ts b/test/translation/transformation.spec.ts
@@ -5,27 +5,32 @@ import { annotationDeprecated } from "../../src/transformation/utils/diagnostics
 import { couldNotResolveRequire } from "../../src/transpilation/diagnostics";
 import * as util from "../util";
 
-const targetSpecs: Array<[string, tstl.LuaTarget | undefined, string]> = [
-    ["", undefined, "./transformation"],
-    ["Luau ", tstl.LuaTarget.Luau, "./transformation/luau"],
-];
+const fixturesPath = path.join(__dirname, "./transformation");
+const fixtures = fs
+    .readdirSync(fixturesPath)
+    .filter(f => path.extname(f) === ".ts")
+    .sort()
+    .map(f => [path.parse(f).name, fs.readFileSync(path.join(fixturesPath, f), "utf8")]);
 
-for (const [name, luaTarget, targetDir] of targetSpecs) {
-    const fixturesPath = path.join(__dirname, targetDir);
-    const fixtures = fs
-        .readdirSync(fixturesPath)
-        .filter(f => path.extname(f) === ".ts")
-        .sort()
-        .map(f => [path.parse(f).name, fs.readFileSync(path.join(fixturesPath, f), "utf8")]);
+test.each(fixtures)("Transformation (%s)", (_name, content) => {
+    util.testModule(content)
+        .setOptions({ luaLibImport: tstl.LuaLibImportKind.Require })
+        .ignoreDiagnostics([annotationDeprecated.code, couldNotResolveRequire.code])
+        .disableSemanticCheck()
+        .expectLuaToMatchSnapshot();
+});
 
-    test.each(fixtures)(`${name}Transformation (%s)`, (_name, content) => {
-        util.testModule(content)
-            .setOptions({
-                luaLibImport: tstl.LuaLibImportKind.Require,
-                luaTarget,
-            })
-            .ignoreDiagnostics([annotationDeprecated.code, couldNotResolveRequire.code])
-            .disableSemanticCheck()
-            .expectLuaToMatchSnapshot();
-    });
-}
+const luauFixturesPath = path.join(fixturesPath, "luau");
+const luauFixtures = fs
+    .readdirSync(luauFixturesPath)
+    .filter(f => path.extname(f) === ".ts")
+    .sort()
+    .map(f => [path.parse(f).name, fs.readFileSync(path.join(luauFixturesPath, f), "utf8")]);
+
+test.each(luauFixtures)("Luau-specific Transformation (%s)", (_name, content) => {
+    util.testModule(content)
+        .setOptions({ luaLibImport: tstl.LuaLibImportKind.Require, luaTarget: tstl.LuaTarget.Luau })
+        .ignoreDiagnostics([annotationDeprecated.code, couldNotResolveRequire.code])
+        .disableSemanticCheck()
+        .expectLuaToMatchSnapshot();
+});
diff --git a/test/unit/builtins/array.spec.ts b/test/unit/builtins/array.spec.ts
@@ -907,9 +907,7 @@ test("new Array()", () => {
         const arr = new Array();
         arr.push(1,2,3);
         return arr;
-    `
-        .debug()
-        .expectToMatchJsResult();
+    `.expectToMatchJsResult();
 });
 
 test("new Array<T>()", () => {
diff --git a/test/unit/loops.spec.ts b/test/unit/loops.spec.ts
@@ -545,6 +545,9 @@ for (const testCase of [
     const expectContinueGotoLabel: util.TapCallback = builder =>
         expect(builder.getMainLuaCodeChunk()).toMatch("::__continue2::");
 
+    const expectContinueStatement: util.TapCallback = builder =>
+        expect(builder.getMainLuaCodeChunk()).toMatch("continue;");
+
     util.testEachVersion(`loop continue (${testCase})`, () => util.testModule(testCase), {
         [tstl.LuaTarget.Universal]: expectContinueVariable,
         [tstl.LuaTarget.Lua50]: expectContinueVariable,
@@ -553,7 +556,7 @@ for (const testCase of [
         [tstl.LuaTarget.Lua53]: expectContinueGotoLabel,
         [tstl.LuaTarget.Lua54]: expectContinueGotoLabel,
         [tstl.LuaTarget.LuaJIT]: expectContinueGotoLabel,
-        [tstl.LuaTarget.Luau]: () => undefined, // TODO: This is N/A.
+        [tstl.LuaTarget.Luau]: () => expectContinueStatement,
     });
 }
 
