Skip to content

Commit 0f1f552

Browse files
committed
Array literal fix
1 parent 03175f1 commit 0f1f552

File tree

4 files changed

+18
-23
lines changed

4 files changed

+18
-23
lines changed

src/TSHelper.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,32 +53,32 @@ export class TSHelper {
5353
}
5454

5555
static isStringType(type: ts.Type): boolean {
56-
return (type.flags & ts.TypeFlags.String) != 0
57-
|| (type.flags & ts.TypeFlags.StringLike) != 0
58-
|| (type.flags & ts.TypeFlags.StringLiteral) != 0
56+
return (type.flags & ts.TypeFlags.String) !== 0
57+
|| (type.flags & ts.TypeFlags.StringLike) !== 0
58+
|| (type.flags & ts.TypeFlags.StringLiteral) !== 0
5959
}
6060

6161
static isArrayType(type: ts.Type): boolean {
62-
return (type.flags & ts.TypeFlags.Object) != 0
62+
return (type.flags & ts.TypeFlags.Object) !== 0
6363
&& (<ts.ObjectType>type).symbol
6464
&& (<ts.ObjectType>type).symbol.escapedName == "Array";
6565
}
6666

6767
static isTupleType(type: ts.Type): boolean {
68-
return (type.flags & ts.TypeFlags.Object) != 0
69-
&& (<ts.TypeReference>type).typeArguments != undefined;
68+
return (type.flags & ts.TypeFlags.Object) !== 0
69+
&& (<ts.TypeReference>type).typeArguments !== undefined;
7070
}
7171

7272
static isCompileMembersOnlyEnum(type: ts.Type, checker: ts.TypeChecker): boolean {
7373
return type.symbol
74-
&& ((type.symbol.flags & ts.SymbolFlags.Enum) != 0)
75-
&& type.symbol.getDocumentationComment(checker)[0] != undefined
74+
&& ((type.symbol.flags & ts.SymbolFlags.Enum) !== 0)
75+
&& type.symbol.getDocumentationComment(checker)[0] !== undefined
7676
&& this.hasCustomDecorator(type, checker, "!CompileMembersOnly");
7777
}
7878

7979
static isPureAbstractClass(type: ts.Type, checker: ts.TypeChecker): boolean {
8080
return type.symbol
81-
&& ((type.symbol.flags & ts.SymbolFlags.Class) != 0)
81+
&& ((type.symbol.flags & ts.SymbolFlags.Class) !== 0)
8282
&& this.hasCustomDecorator(type, checker, "!PureAbstract");
8383
}
8484

@@ -90,13 +90,13 @@ export class TSHelper {
9090

9191
static isPhantom(type: ts.Type, checker: ts.TypeChecker): boolean {
9292
return type.symbol
93-
&& ((type.symbol.flags & ts.SymbolFlags.Namespace) != 0)
93+
&& ((type.symbol.flags & ts.SymbolFlags.Namespace) !== 0)
9494
&& this.hasCustomDecorator(type, checker, "!Phantom");
9595
}
9696

9797
static isTupleReturnFunction(type: ts.Type, checker: ts.TypeChecker): boolean {
9898
return type.symbol
99-
&& ((type.symbol.flags & ts.SymbolFlags.Function) != 0)
99+
&& ((type.symbol.flags & ts.SymbolFlags.Function) !== 0)
100100
&& this.hasCustomDecorator(type, checker, "!TupleReturn");
101101
}
102102

src/Transpiler.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -795,9 +795,10 @@ export class LuaTranspiler {
795795
case ts.TypeFlags.String:
796796
case ts.TypeFlags.StringLiteral:
797797
return this.transpileStringCallExpression(node);
798-
case ts.TypeFlags.Object:
799-
if (tsEx.isArrayType(expType))
800-
return this.transpileArrayCallExpression(node);
798+
799+
}
800+
if (tsEx.isArrayType(expType)) {
801+
return this.transpileArrayCallExpression(node);
801802
}
802803

803804
if (expType.symbol && (expType.symbol.flags & ts.SymbolFlags.Namespace)) {

test/integration/lua/loops.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Expect, Test, TestCase } from "alsatian";
1+
import { Expect, Test, TestCase, FocusTest } from "alsatian";
22
import * as util from "../../src/util"
33

44
const deepEqual = require('deep-equal')
@@ -184,6 +184,7 @@ export class LuaLoopTests {
184184

185185
@TestCase([0, 1, 2], [1, 2, 3])
186186
@Test("forof")
187+
@FocusTest
187188
public forof(inp: any, expected: any) {
188189
// Transpile
189190
let lua = util.transpileString(
@@ -194,6 +195,7 @@ export class LuaLoopTests {
194195
}
195196
return JSONStringify(arrResultTest);`
196197
);
198+
console.log(lua);
197199

198200
// Execute
199201
let result = util.executeLua(lua);

test/src/util.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,6 @@ export function transpileString(str: string, options: CompilerOptions = { dontRe
3939
return result.trim();
4040
}
4141

42-
function printAST(node: ts.Node, indent: number) {
43-
let indentStr = "";
44-
for (let i = 0; i < indent; i++) indentStr += " ";
45-
46-
console.log(indentStr + tsEx.enumName(node.kind, ts.SyntaxKind));
47-
node.forEachChild(child => printAST(child, indent + 1));
48-
}
49-
5042
export function transpileFile(path: string): string {
5143
const program = ts.createProgram([path], {});
5244
const checker = program.getTypeChecker();

0 commit comments

Comments
 (0)