Change class initialization order (#1458)

Perryvw · web-flow · commit 0e5df55f4fba · 2023-06-11T22:29:18.000+02:00
diff --git a/src/transformation/visitors/class/index.ts b/src/transformation/visitors/class/index.ts
@@ -160,6 +160,17 @@ function transformClassLikeDeclaration(
     }
 
     // Transform class members
+
+    // First transform the methods, in case the static properties call them
+    for (const member of classDeclaration.members) {
+        if (ts.isMethodDeclaration(member)) {
+            // Methods
+            const statements = transformMethodDeclaration(context, member, localClassName);
+            result.push(...statements);
+        }
+    }
+
+    // Then transform the rest
     for (const member of classDeclaration.members) {
         if (ts.isAccessor(member)) {
             // Accessors
@@ -170,10 +181,6 @@ function transformClassLikeDeclaration(
             if (accessorsResult) {
                 result.push(accessorsResult);
             }
-        } else if (ts.isMethodDeclaration(member)) {
-            // Methods
-            const statements = transformMethodDeclaration(context, member, localClassName);
-            result.push(...statements);
         } else if (ts.isPropertyDeclaration(member)) {
             // Properties
             if (isStaticNode(member)) {
diff --git a/test/unit/classes/classes.spec.ts b/test/unit/classes/classes.spec.ts
@@ -818,3 +818,18 @@ test("static initialization block (#1447)", () => {
         export const result2 = A.staticProperty3;
     `.expectToMatchJsResult();
 });
+
+// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1457
+test("static member definition order (#1457)", () => {
+    util.testFunction`
+        class A {
+            static a = A.foo()
+        
+            static foo(): number {
+                return 5
+            }
+        }
+        
+        return A.a;
+    `.expectToMatchJsResult();
+});
