Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
approved these changes
Jun 12, 2024
Collaborator
YousefED
left a comment
YousefED
left a comment
There was a problem hiding this comment.
Nice. Did you also check if there were updates to the mantine css we need to copy?
Collaborator
Author
Good question, checked and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging PR #652 and releasing v0.13.0, we ended up having a Mantine version regression from
7.7.1to7.5.0. This is important as7.7.1updated hash-css-selector to1.1.0, which changes CSS module classes to use underscores instead of hyphens.This fixes bugs which can occur when importing BlockNote CSS files, as CSS processors and build tools sometimes change hyphens in the class names to underscores (I think this is because accessing them requires using
styles["class-name"]instead ofstyles.class_name). This in turn means that components have mismatched class names with the stylesheets and the styles don't get applied.This PR updates Mantine to the newest version,
7.10.1.