Fix AI combobox aria-activedescendant#2413
Open
Ovgodd wants to merge 1 commit intoTypeCellOS:mainfrom
Open
Conversation
|
@Ovgodd is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes AI suggestion menu accessibility by wiring
aria-activedescendantto the active option so screen readers announce the current item during keyboard navigation.issue : #2412
Rationale
The combobox/listbox pattern keeps focus on the input, so the active option must be exposed via
aria-activedescendant. Without it, NVDA/VoiceOver announce “empty” and provide no feedback. This change aligns with WAI-ARIA Authoring PracticesChanges
PromptSuggestionMenuand setaria-activedescendanton the input.Generic.Form.TextInputprops to acceptaria-activedescendant.Impact
Testing
Screenshots/Video
Sr announce now :
N/A (accessibility change).
Checklist
Additional Notes
This fix targets only the AI suggestion menu combobox. Future work could add
aria-expanded/aria-controlsfor full parity with the ARIA combobox pattern.