feat: allow customizing the rendering of video and audio elements #2203#2250
Open
nperez0111 wants to merge 1 commit intomainfrom
Open
feat: allow customizing the rendering of video and audio elements #2203#2250nperez0111 wants to merge 1 commit intomainfrom
nperez0111 wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
reviewed
Dec 15, 2025
Collaborator
YousefED
left a comment
YousefED
left a comment
There was a problem hiding this comment.
Makes sense, couple of questions to nail this:
- should we use the name
render? (it's a term we use in other places as well, so might get confusing? Or good for consistency?) - Can we add a simple test for this?
- Do we want to implement this at the React layer (React File blocks) as well? Or rather first determine what our strategy is in the react vs native file blocks?
Contributor
Author
🤷 I haven't got a better name at the moment.
Of course.
Now that you mention this, I think this might go a bit deeper, whether this is working towards or against the idea of separating the schema config from it's rendering. Like maybe a user could choose to override the rendering to put whatever they want instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An attempt to supercede #2229
Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes
Resolves #2203