Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
Oct 27, 2025
Contributor
nperez0111
left a comment
nperez0111
left a comment
There was a problem hiding this comment.
I'm not entirely certain about this change, the low contrast was fairly intentional to make it not look like the normal text. I am unsure that we actually need to apply the guidelines for what is essentially decorative text.
I'll let @YousefED decide here though
Collaborator
|
There's a difficult trade-off here (improving accessibility vs staying more inline with other visual design decisions). My preference would be to expose this as a separate option / theme. For now - let's hold off on merging this directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the the value set for the
--bn-colors-side-menuCSS variable in the default light and dark themes, has a contrast that is too low relative to the--bn-colors-editor-backgroundvariable.This is relevant because it's used for the side menu and block placeholder text colors, and doesn't comply with WCAG accessibility standards.
This PR changes the value of
--bn-colors-side-menuto comply with the WCAG 2 AAA standard.Closes #1983
Rationale
Useful improvement for vision impaired users.
Changes
Updated
--bn-colors-side-menuCSS variable value for light and dark default themes.Impact
N/A
Testing
N/A
Screenshots/Video
N/A
Checklist
Additional Notes