forked from http-party/node-http-proxy
-
Notifications
You must be signed in to change notification settings - Fork 0
Return value... #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Angelfirenze
wants to merge
204
commits into
Tug:master
Choose a base branch
from
IntotheCode01:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix] only set one drain listener while paused
This reverts commit 9f92332.
Instead, just perform a request.
Conflicts: lib/node-http-proxy/http-proxy.js
… longer set synchronously
…-https-to-https.js, lines 37 and 46
…iscover when you run into it. If there was an error, people would search for the error text, but there isn't.
proposed doc addition for http-party#180
[docs] improved grammar
[docs] Making README links consistent with latest project structure.
…to be consistent with `proxyError` events.
…t be a string, not undefined' in certain cases
Mention Harmon used for response modifications in the readme
…ce to reduce listener churn and reference counts.
Fixing a bug that generates an unexpected TypeError
Change the emitter of the `proxyResponse` event
Fix for slab buffer retention, leading to large memory consumption
Since the proxy requests comes from NodeJS's HTTP 1.1 request client, a backend server may default to setting Connection: keep-alive in its response. However, the real HTTP 1.0 client may not be able to handle that. Force HTTP 1.0 client's to Connection: close, unless the client explicitly supports keep-alive.
Correct keep-alive responses to HTTP 1.0 clients
The headers in the 'handshake' event were not written to the socket, the client received data but not the headers.
Using only SNICallback to create a HTTPS / TLS server is bad. It means all non SNI clients can't do anything because there are no certs. in v0.10 of node TLS server was updated to throw if you forgot to supply certs. Which means that every HTTPS server needs to supply certs as a fallback for when SNI is not available. - closes http-party#399
Pass default certs to SNICallback example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that the enormous amount of people working on this project manage to get it as close to perfect as possible and it's released. Will the general coding public be able to benefit soon -- or how much could someone like myself who has at least a head start with JavaScript be able to assist any time soon because of the learning opportunities this provides for a better grasp on JS, itself? Is there room here where I can utilize anything to help and learn at the same time?