Skip to content

Bugfix/issue 125 syntax error in g 7910 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippSalvisberg merged 3 commits into from
Aug 12, 2022
Merged

Bugfix/issue 125 syntax error in g 7910 #145

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae29de0
fix syntax errors in good and bad example of G-7910
PhilippSalvisberg Aug 12, 2022
5638965
rename input parameter to match our naming conventions
PhilippSalvisberg Aug 12, 2022
f6fc0c9
reformatted return SQL statement to avoid horizontal scrolling in HTM…
PhilippSalvisberg Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions docs/4-language-usage/7-stored-objects/9-sql-macros/g-7910.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,33 @@ Logging macro calls via a call to a procedure that does DML in an autonomous tra
## Example (bad)

``` sql
create or replace function row_generator (
num_rows_in in number(32,0)
create or replace function row_generator(
in_num_rows in number
)
return varchar2 sql_macro as
begin
insert into function_calls(name, called_at, parameter_value)
values ($$PLSQL_UNIT, current_timestamp, num_rows_in);
insert into function_calls(name,called_at,parameter_value)
values ($$plsql_unit,current_timestamp,in_num_rows);
commit;

return 'select level as row_sequence from dual connect by level <= num_rows_in';

return 'select level as row_sequence
from dual
connect by level <= in_num_rows';
end row_generator;
/
```

## Example (good)

``` sql
create or replace function row_generator (
num_rows_in in number(32,0)
create or replace function row_generator(
in_num_rows in number
)
return varchar2 sql_macro as
begin
return 'select level as row_sequence from dual connect by level <= num_rows_in';
return 'select level as row_sequence
from dual
connect by level <= in_num_rows';
end row_generator;
/
```