Conversation
It shouldn't be possible to walk into a 5-man instance while a boss fight is in progress. That’s how it was in the 2009 original, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It shouldn't be possible to walk into a 5-man instance while a boss fight is in progress. That’s how it was in the 2009 original, too.
Removing this line causes not only raids but also dungeons to be checked.
Various archive forum posts confirm this.:
https://eu.forums.blizzard.com/en/wow/t/unable-to-zone-in-while-an-encounter-is-in-progess/21536
https://www.reddit.com/r/wow/comments/trtsbp/queue_pop_unable_to_enter_dungeon_due_to/
https://us.forums.blizzard.com/en/wow/t/lfr-cant-zone-me-in-encounter-in-progress/1090020/2
"The restriction is definitely blizzlike for WotLK. In the original 3.3.5a client's GlobalStrings.lua, Blizzard hardcoded TRANSFER_ABORT_ZONE_IN_COMBAT = "You cannot enter the instance while an encounter is in progress.". Whenever the Dungeon Finder (RDF) auto-teleported a replacement player into a 5-man dungeon while the remaining party was in combat, the server sent TRANSFER_ABORT_ZONE_IN_COMBAT and aborted the loading screen. It's handled by the base Map class (MapEncounterInProgress), which applies to both InstanceMap (5-man) and RaidMap inside the engine."Tests performed:
Testet ingame and works