Core/Items: Add durability sell penalty when selling damaged items to…#31841
Open
kik0desu wants to merge 3 commits into
Open
Core/Items: Add durability sell penalty when selling damaged items to…#31841kik0desu wants to merge 3 commits into
kik0desu wants to merge 3 commits into
Conversation
|
I just can't remember if this is blizzlike but I do remember on some servers I've played on another scenario where vendor doesn't want your item till you repair it. |
Member
|
What is the point of this function you added? It's exactly a copypaste of |
Author
I just didn't want to modify the existing function to add a new parameter, afaik the rate config should not affect the sell cost at all. |
Author
|
did an update, lmk if it's better like this |
Shauren
reviewed
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… vendors
Changes proposed:
Issues addressed:
none
Tests performed:
builds, tested in-game
before:
sellcost.durability.fix.before.mp4
after:
sellcost.durability.fix.after.mp4