Skip to content

Fix AppleClang build.#31808

Open
r4d1sh wants to merge 6 commits into
TrinityCore:3.3.5from
r4d1sh:macOS_fixes
Open

Fix AppleClang build.#31808
r4d1sh wants to merge 6 commits into
TrinityCore:3.3.5from
r4d1sh:macOS_fixes

Conversation

@r4d1sh
Copy link
Copy Markdown

@r4d1sh r4d1sh commented Apr 19, 2026

Changes proposed:

  • Just a few commits and cherry-picks that fix build errors and warnings with AppleClang 21.0.0 on macOS Tahoe 26.4.1

Tests performed:

Successfully builded (PCH/noPCH, WITH_WARNINGS=1, no errors, no warnings).

@Shauren
Copy link
Copy Markdown
Member

Shauren commented Apr 21, 2026

2a178ac was intentionally left out of a different PR porting stuff from master (you will have to live with the warning)
edc6263 why is this needed? master branch doesn't have anything like this and builds and links without warnings, see https://github.com/TrinityCore/TrinityCore/actions/runs/24674562722/job/72154711400

@r4d1sh
Copy link
Copy Markdown
Author

r4d1sh commented Apr 21, 2026

edc6263 why is this needed? master branch doesn't have anything like this and builds and links without warnings, see https://github.com/TrinityCore/TrinityCore/actions/runs/24674562722/job/72154711400

As far as I can tell, it uses a relatively old version of AppleClang (15 vs. 21). I think the issue is that in the new toolchain, the order or method of building static libraries with ranlib has changed.

@r4d1sh
Copy link
Copy Markdown
Author

r4d1sh commented Apr 23, 2026

2a178ac was intentionally left out of a different PR porting stuff from master (you will have to live with the warning)

Btw why?

@Shauren
Copy link
Copy Markdown
Member

Shauren commented Apr 24, 2026

2a178ac was intentionally left out of a different PR porting stuff from master (you will have to live with the warning)

Btw why?

That would be because it is just a warning and it was changed (in a different way) in a different commit in master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants