Core/Garrisons: Allow players to have multiple garrisons (one per type)#31636
Open
Golrag wants to merge 4 commits intoTrinityCore:masterfrom
Open
Core/Garrisons: Allow players to have multiple garrisons (one per type)#31636Golrag wants to merge 4 commits intoTrinityCore:masterfrom
Golrag wants to merge 4 commits intoTrinityCore:masterfrom
Conversation
Golrag
force-pushed
the
garrisons_multiple
branch
from
f7e1649 to
c623b98
Compare
Shauren
reviewed
Feb 2, 2026
| #include "Player.h" | ||
| #include "VehicleDefines.h" | ||
| #include "advstd.h" | ||
| #include <ranges> |
Member
|
Why did you decide to make |
Contributor
Author
|
I wanted to have an class that would handle and/or delegate to the correct garrison. So that player->GetGarrison()->AddFollower would work without needing to know to which garrison said follower exists (at least not in the place calling this). Whether or not this was a good idea given the usecases in CriteriaHandler is something im not sure about I had thoughts about either introducing a new class in between them, or moving the followers, buildings etc to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
Closes:
Tests performed:
Known issues and TODO list: