Skip to content

Scripts/ICC: update Gunship Battle scripts to new model#25438

Merged
jackpoz merged 2 commits intoTrinityCore:3.3.5from
ForesterDev:igb_update
Sep 18, 2020
Merged

Scripts/ICC: update Gunship Battle scripts to new model#25438
jackpoz merged 2 commits intoTrinityCore:3.3.5from
ForesterDev:igb_update

Conversation

@ForesterDev
Copy link
Contributor

Changes proposed:

  • update Gunship Battle scripts to new model

Target branch(es): 3.3.5/master

  • 3.3.5
  • master

Tests performed:

Build

@jackpoz
Copy link
Member

jackpoz commented Sep 10, 2020

Pull requests that are not tested ingame should be opened as draft. Test it, ensure it doesn't throw any startup error, ensure it doesn't trigger an assert on startup, ensure it works and then please mark the PR as ready to be reviewed.

@jackpoz jackpoz marked this pull request as draft September 10, 2020 12:25
@ForesterDev ForesterDev marked this pull request as ready for review September 15, 2020 10:18
@ForesterDev
Copy link
Contributor Author

Tested:

  • any startup error
  • doesn't trigger an assert on startup
  • it works

@jackpoz jackpoz merged commit 2e1a6ae into TrinityCore:3.3.5 Sep 18, 2020
Shauren pushed a commit that referenced this pull request Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants