Skip to content

Scripts/ICC: update Sindragosa scripts to new model#25395

Merged
jackpoz merged 1 commit intoTrinityCore:3.3.5from
ForesterDev:sindragosa_update
Sep 4, 2020
Merged

Scripts/ICC: update Sindragosa scripts to new model#25395
jackpoz merged 1 commit intoTrinityCore:3.3.5from
ForesterDev:sindragosa_update

Conversation

@ForesterDev
Copy link
Contributor

Changes proposed:

  • update Sindragosa scripts to new model

Target branch(es): 3.3.5/master

  • 3.3.5
  • master

Tests performed:

Build

@jackpoz jackpoz merged commit deec517 into TrinityCore:3.3.5 Sep 4, 2020
@jackpoz
Copy link
Member

jackpoz commented Sep 4, 2020

Thanks for the PR :)

@jackpoz
Copy link
Member

jackpoz commented Sep 4, 2020

D:\wow\TrinityCore\src\server\game\Scripting\ScriptMgr.cpp:793 in SpecializedScriptRegistry<class SpellScriptLoader,1>::AddScript ABORTED:
Script 'spell_sindragosa_ice_tomb' already assigned with the same script name, so the script can't work.

could it be this PR just killed worldserver ?

@jackpoz
Copy link
Member

jackpoz commented Sep 4, 2020

Tests performed:

Build

Please next time start at least worldserver...

@jackpoz
Copy link
Member

jackpoz commented Sep 6, 2020

Script named 'npc_rimefang' does not have a script name assigned in database.
ScriptName 'npc_rimefang_icc' exists in database, but no core script found!

@jackpoz
Copy link
Member

jackpoz commented Sep 6, 2020

this in the end was one of the most bugged PRs I ever merged. Next time I will put it back in draft if I don't see a Server.log attached clean of errors and an ingame video of the script still working correctly

@ghost
Copy link

ghost commented Sep 6, 2020

Looks like there is no GitHub build check to pick up on the same type of error as DBErrors.log on a running server.

Shauren pushed a commit that referenced this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants