[Retail] Mounting or interacting with objects triggers infinite Hero Talent proc loop #31949

Description

Current behaviour

On current upstream master, Retribution Paladin Hero Talent spells enter an infinite proc loop.

The issue can be reproduced by mounting or interacting with certain world objects (for example the Stormwind command board).

The server repeatedly logs:

Unit::ProcSkillsAndAuras: Possible infinite proc loop detected

Investigation shows the following proc chain:

210372 Blessing of Dawn
-> Aura 387170
-> 387178 Empyrean Legacy
-> Aura 427445
-> 427441 Hammer of Light
-> Aura 387170
-> ...

until TrinityCore aborts the proc chain because the proc depth limit is reached.

Expected behaviour

The Hero Talent spells should not recursively proc each other.

Steps to reproduce the problem

1. Use current upstream master.
2. Create / log into a Retribution Paladin with the corresponding Hero Talents.
3. Mount or interact with the Stormwind board.
4. Observe Hero Talent buffs being repeatedly applied and the server logging an infinite proc loop.

Branch

master

TC rev. hash/commit

a62ad24

Operating system

Windows 11 x64

Custom changes

hotfix_data
item_sparse
item_extended_cost