TVAULT-2334 #4
Open
TVAULT-2334 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amitkumar-a4 @MuralidharB Can you please confirm if these changes are good to go with the build? |
MuralidharB
reviewed
Mar 19, 2018
MuralidharB
left a comment
MuralidharB
left a comment
There was a problem hiding this comment.
Do we need these as part of our triliovault image? They look specific to large scale setup.
|
As we would be loading 3.0 builds on scale setup before the release , we would need these changes in tvault image. |
|
@amitkumar-a4 @MuralidharB can you please update here. |
Author
|
I don't think so we required this in the build? As this change is specific to large scale, the reason could be somewhere specific to our large scale environment. The root cause is still unknown for this. Having this fix in the build will increase unnecessary call during each operation of TVM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.