Merged
Conversation
juanborre
approved these changes
May 13, 2020
Contributor
juanborre
left a comment
juanborre
left a comment
There was a problem hiding this comment.
Cool. Just one comment
|
|
||
| Describe the development environment. Include basic instructions--does this repository prefer `npm ci` or `npm i`? Does prettier run on save? Any special settings or extensions you should set up in your IDE? | ||
|
|
||
| If you're not sure where to start, consider explaining the npm scripts that might be relevent for getting a development environment |
Contributor
There was a problem hiding this comment.
Probably here we should add the environment variables needed to run it or to modify its behaviour.
Contributor
Author
There was a problem hiding this comment.
Good call, thank you!
rsecob
approved these changes
May 13, 2020
rsecob
left a comment
rsecob
left a comment
There was a problem hiding this comment.
great initiative, thank you for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7