Added Loading State for ListView Component#15681
Open
rahulprasad00 wants to merge 4 commits intolts-3.16from
Open
Added Loading State for ListView Component#15681rahulprasad00 wants to merge 4 commits intolts-3.16from
rahulprasad00 wants to merge 4 commits intolts-3.16from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable loading state to the Listview widget so apps can display a spinner while data is being fetched, and backfills defaults for existing saved components to preserve compatibility.
Changes:
- Added
loadingStatetoggle to Listview widget config (server + frontend) with default{{false}}. - Updated Listview widget rendering to show a
SpinnerwhenloadingStateis enabled. - Added backfill logic via import/export migration code and a DB data migration for existing
componentsrows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/modules/apps/services/widget-config/listview.js | Adds loadingState property + default definition for Listview (server-side config). |
| frontend/src/AppBuilder/WidgetManager/widgets/listview.js | Mirrors server config change for Listview (frontend widget config). |
| frontend/src/AppBuilder/Widgets/Listview/Listview.jsx | Renders spinner + applies loading class when loadingState is true. |
| server/src/modules/apps/services/app-import-export.service.ts | Adds Listview to revamped component list and backfills loadingState during import migrations. |
| server/data-migrations/1774412653881-BackfillLoadingStateListView.ts | Backfills properties.loadingState for existing Listview components in DB. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shaurya-sharma064
approved these changes
Mar 25, 2026
shaurya-sharma064
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: Issue