(Re)implementet flash and draft76 support #41
(Re)implementet flash and draft76 support #41TooTallNate merged 5 commits intoTooTallNate:masterfrom
Conversation
-completed basic client side draft10 opening handshake
-generalized Handshakedata handling
There was a problem hiding this comment.
This could probably be cached for speed (as a private static final I suppose).
There was a problem hiding this comment.
That would be better.
This code will be excecuted once per handshake.
I will change that with my next commit, if you dont do it during merging.
There was a problem hiding this comment.
Go ahead and fix, I'll wait.
|
Thanks for this! Couple fixes: Not a huge deal, but it would be nice if the Drafts in the dropdown list on the ChatClient were in reverse order, such that Draft 10 is the default one selected. Also, attempting to connect to the test ChatServer using the CharClient and Draft 75 disconnects immediately. Might not be too important since there's no browsers using that draft anymore, but maybe you could look quickly before I merge. Thanks again! |
|
-added much stronger validation to ALL drafts Tested all clients with ws://echo.websocket.org and local with the chat example. @TooTallNate the requested fixes/changes are included |
-made all drafts working as client and server -generalized handshake -minor requested changes
(Re)implementet flash and draft76 support
|
@Davidiusdadi Thanks! Merged! |
(Re)implementet flash and draft76 support
2 participants
The commit messages should explain the changes and additions.
I tested the flash edge case on IE and Opera.
I tested draft76 on Opera and via the chat example.
draft75 is a subset of draft76 and might work but i did not tested it since i have no draft75 running browser...