Fixed sieve (OmkarPathak#93)

rathod-sahaab · OmkarPathak · commit 9fab4749ca13 · 2019-10-07T10:01:21.000+05:30
* Fixed sieve
- Algo now printing n when if prime
- updated tests

* Removed extra 'this'
diff --git a/pygorithm/math/sieve_of_eratosthenes.py b/pygorithm/math/sieve_of_eratosthenes.py
@@ -29,15 +29,15 @@ def sieve_of_eratosthenes(n):
     p = 2
 
     while p * p <= n:
-        # if p is not marked as False, this it is a prime
+        # if p is not marked as False, it is a prime
         if primes[p]:
             # mark all the multiples of number as False
             for i in range(p * 2, n + 1, p):
                 primes[i] = False
         p += 1
 
     # getting all primes
-    primes = [element for element in range(2, n) if primes[element]]
+    primes = [element for element in range(2, n + 1) if primes[element]]
 
     return primes
 
diff --git a/tests/test_math.py b/tests/test_math.py
@@ -17,7 +17,7 @@ def test_lcm_using_gcd(self):
 
 class TestSieveOfEratosthenes(unittest.TestCase):
     def test_sieve_of_eratosthenes(self):
-        self.assertEqual(sieve_of_eratosthenes.sieve_of_eratosthenes(10), [2, 3, 5, 7])
+        self.assertEqual(sieve_of_eratosthenes.sieve_of_eratosthenes(11), [2, 3, 5, 7, 11])
 
 class TestFactorial(unittest.TestCase):
     def test_factorial(self):
