Fix errors and panics in the chirpstack v3 source #111
Merged
KrishnaIyer merged 4 commits intomasterfrom Mar 4, 2024
Merged
Conversation
adriansmares
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix errors and panics in the chirpstack v3 source. Ref: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1029
Changes
insecureis not set.grpc.WithInsecure()method.ClientConnfield on theSourceso that the underlying one from theConfigmay be used.Testing
Local with a ChirpStack v4 instance. This of course doesn't check actual migration but makes sure that the tool doesn't panic.
This will be tested by CE as a part of https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1029.
Regressions
NA. This is fixing existing bugs.
Checklist
CHANGELOG.md.