Add File Input Output In OCaml#5975
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
rzuckerm
requested changes
May 18, 2026
Comment on lines
+22
to
+23
| Out_channel.with_open_text filename (fun oc -> | ||
| Out_channel.output_string oc sample_text) |
Collaborator
There was a problem hiding this comment.
This should be written 1 line at a time.
Contributor
Author
There was a problem hiding this comment.
This is the way that ocamlformat autoformats the file with the default profile. If you put the lambda on a separate line, it reformats the file back to this. I think for a sample program repository it makes sense to follow the convention set out by the language.
Comment on lines
+3
to
+8
| (* Some arbitrary interesting text for demo file reading and writing. | ||
| These are the 10 thunderwords from Joyce's Finnegans Wake. | ||
| See here for a great literary explanation if you're interested: | ||
| https://hatterscabinet.com/pages-fw/fwtheme-thunderwords.html *) | ||
| let sample_text = | ||
| {|bababadalgharaghtakamminarronnkonnbronntonnerronntuonnthunntrovarrhounawnskawntoohoohoordenenthurnuk |
Collaborator
There was a problem hiding this comment.
I think I'd prefer something a little more mundane than this
Contributor
Author
There was a problem hiding this comment.
Done, increased mundanity.
rzuckerm
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I Am Adding a New Code Snippet in an Existing Language
Add {PROJECT} in {LANGUAGE}format