Skip to content

Add Sleep Sort in C#4363

Merged
rzuckerm merged 17 commits into
TheRenegadeCoder:mainfrom
2Clutch:main
Jan 20, 2025
Merged

Add Sleep Sort in C#4363
rzuckerm merged 17 commits into
TheRenegadeCoder:mainfrom
2Clutch:main

Conversation

@2Clutch
Copy link
Copy Markdown
Contributor

@2Clutch 2Clutch commented Jan 19, 2025

I Am Adding a New Code Snippet in an Existing Language

@github-advanced-security
Copy link
Copy Markdown

github-advanced-security AI commented Jan 19, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

rzuckerm
rzuckerm requested changes Jan 19, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this isn't how Sleep Sort works. It involves spinning up threads that sleep for the requested amount of time and put the value into a queue that can be output later. Please see the project requirements

@2Clutch
Copy link
Copy Markdown
Contributor Author

2Clutch commented Jan 19, 2025 •
edited
Loading

Sorry, but this isn't how Sleep Sort works. It involves spinning up threads that sleep for the requested amount of time and put the value into a queue that can be output later. Please see the project requirements

the thread solution causes issue with the checks even after adding -pthread to the build command, and I'm not sure I can update those. i honestly wouldn't want to do it tbh.

edit 1: nvm. looks like it worked fine with threading. not sure what i was doing wrong before

@2Clutch 2Clutch requested a review from rzuckerm January 19, 2025 20:23
rzuckerm
rzuckerm requested changes Jan 19, 2025
View reviewed changes
Comment thread archive/c/c/sleep-sort.c Outdated
Comment thread archive/c/c/sleep-sort.c Outdated
Comment thread archive/c/c/sleep-sort.c Outdated
@rzuckerm rzuckerm added enhancement Any code that improves the repo sleep sort labels Jan 19, 2025
rzuckerm
rzuckerm approved these changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing one of the more difficult samples, @2Clutch ! You're well on your way to completing all the C samples.

@rzuckerm rzuckerm merged commit 746cbd0 into TheRenegadeCoder:main Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzuckerm rzuckerm rzuckerm approved these changes

Assignees

No one assigned

Labels

enhancement Any code that improves the repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Sleep Sort in C

3 participants

@2Clutch @github-advanced-security @rzuckerm