Skip to content

feat: Concatenate both factorial implementations#8099

Merged
cclauss merged 2 commits intoTheAlgorithms:masterfrom
CaedenPH:concatenate-factorial
Jan 26, 2023
Merged

feat: Concatenate both factorial implementations#8099
cclauss merged 2 commits intoTheAlgorithms:masterfrom
CaedenPH:concatenate-factorial

Conversation

@CaedenPH
Copy link
Copy Markdown
Contributor

@CaedenPH CaedenPH commented Jan 25, 2023

Describe your change:

Implements #8098

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jan 25, 2023
@CaedenPH
Copy link
Copy Markdown
Contributor Author

CaedenPH commented Jan 25, 2023

@cclauss What is your opinion?

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jan 26, 2023 •
edited
Loading

Looks great! Please add a benchmark of factorial() vs. factorial_recursive() vs. math.factorial(). It is OK if the latter is much faster than the other two.

@CaedenPH
Copy link
Copy Markdown
Contributor Author

CaedenPH commented Jan 26, 2023

Looks great! Please add a benchmark of factorial() vs. factorial_recursive() vs. math.factorial(). It is OK if the latter is much faster than the other two.

Can I add this in another pull request? This is just for concatenating implementations, not adding features

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jan 26, 2023
@cclauss cclauss merged commit c00af45 into TheAlgorithms:master Jan 26, 2023
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@CaedenPH @Cjkjvfnby
feat: Concatenate both factorial implementations (TheAlgorithms#8099)
971a543 
* feat: Concatenate both factorial implementations

* fix: Rename factorial recursive method
@CaedenPH CaedenPH deleted the concatenate-factorial branch August 21, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH @cclauss