Skip to content

add check : PrefixSum.get_sum start should be less or equal to the end.#7961

Closed
alexpantyukhin wants to merge 4 commits intoTheAlgorithms:masterfrom
alexpantyukhin:prefix_sum_index_range_check
Closed

add check : PrefixSum.get_sum start should be less or equal to the end.#7961
alexpantyukhin wants to merge 4 commits intoTheAlgorithms:masterfrom
alexpantyukhin:prefix_sum_index_range_check

Conversation

@alexpantyukhin
Copy link
Copy Markdown
Member

@alexpantyukhin alexpantyukhin commented Nov 4, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 4, 2022
@zhudingsuifeng
Copy link
Copy Markdown

zhudingsuifeng commented Nov 4, 2022 via email

@BCGL
Copy link
Copy Markdown

BCGL commented Nov 4, 2022 via email

@wwowowo
Copy link
Copy Markdown

wwowowo commented Nov 4, 2022 via email

CaedenPH
CaedenPH reviewed Nov 4, 2022
View reviewed changes
@alexpantyukhin @CaedenPH
Update data_structures/arrays/prefix_sum.py
96f215b 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 5, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 5, 2022
@algorithms-keeper algorithms-keeper bot mentioned this pull request Nov 24, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexpantyukhin @zhudingsuifeng @BCGL @wwowowo @CaedenPH