Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| printed and hence list is sorted""" | ||
|
|
||
|
|
||
| def sleep_sort(values): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function sleep_sort
Please provide return type hint for the function: sleep_sort. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: values
| def sleep_sort(values): | ||
| sleep_sort.result = [] | ||
|
|
||
| def add1(x): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function add1
Please provide return type hint for the function: add1. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| printed and hence list is sorted""" | ||
|
|
||
| def sleep_sort(values): | ||
| sleep_sort.result = [] |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function sleep_sort
Please provide return type hint for the function: sleep_sort. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: values
| sleep_sort.result = [] | ||
| def add1(x): | ||
| sleep_sort.result.append(x) | ||
| mx = values[0] |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleep_sort.py, please provide doctest for the function add1
Please provide return type hint for the function: add1. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: x
Please provide descriptive name for the parameter: x
cclauss
added
the
ON HOLD: Final hours of Hacktoberfest
2 participants
Describe your change:
I have added a sorting algorithm in 'sort' folder named "sleep_sort".
Checklist:
Fixes: #{$ISSUE_NO}.