Merged
Conversation
Finding the intensity of light transmitted through a polariser using Malus Law and by taking initial intensity and angle between polariser and axis as input
for more information, see https://pre-commit.ci
CaedenPH
reviewed
Oct 27, 2022
Contributor
CaedenPH
left a comment
CaedenPH
left a comment
There was a problem hiding this comment.
@SparshRastogi fix the failing pre-commit (lines too long), commit my changes and then this pr will be ready for merge.
Great work!
physics/malus_law.py
Outdated
| ) | ||
| # handling of values out of allowed range | ||
| final_intensity = initial_intensity * (math.cos(math.radians(angle)) ** 2) | ||
| return round(final_intensity, 2) |
Contributor
There was a problem hiding this comment.
Why round the result?
Suggested change
| return round(final_intensity, 2) | |
| return final_intensity |
You should keep the precision and round it in the tests
Contributor
Author
There was a problem hiding this comment.
Yes,thank you for the suggestion,made changes to round in the testcases instead of main code
Closed
14 tasks
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Made some changes in the error messages and the docstring testcases
algorithms-keeper
bot
removed
the
tests are failing
Made changes for the passing the precommit
for more information, see https://pre-commit.ci
cclauss
approved these changes
Oct 27, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding the intensity of light transmitted through a polariser using Malus Law and by taking initial intensity and angle between polariser and axis as input
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.