Create largest_square_area_in_matrix.py by kondekarshubham123 · Pull Request #7673 · TheAlgorithms/Python

kondekarshubham123 · 2022-10-26T14:13:05Z

Describe your change:

Added my approach for following question

Question:
Given a binary matrix mat of size n * m, find out the maximum size square
sub-matrix with all 1s.

Example 1:

Input:
n = 2, m = 2
mat = [[1, 1],
[1, 1]]

Output:
2

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-26T14:13:15Z

+    0
+    """
+
+    def update_area_of_max_square(row: int, col: int) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square

algorithms-keeper · 2022-10-26T14:13:15Z

+    >>> largest_square_area_in_matrix_top_down_approch_with_dp(2, 2, [[0,0], [0,0]])
+    0
+    """
+    def update_area_of_max_square_using_dp_array(row: int, col: int, dp_array: List[List[int]]) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-26T14:15:29Z

+    0
+    """
+
+    def update_area_of_max_square(row: int, col: int) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square

algorithms-keeper · 2022-10-26T14:15:30Z

+    0
+    """
+
+    def update_area_of_max_square_using_dp_array(


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array

CaedenPH

Looks good - small changes

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-26T14:48:09Z

+    0
+    """
+
+    def update_area_of_max_square(row: int, col: int) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square

algorithms-keeper · 2022-10-26T14:48:09Z

+    0
+    """
+
+    def update_area_of_max_square_using_dp_array(


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-26T14:48:26Z

+    0
+    """
+
+    def update_area_of_max_square(row: int, col: int) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square

algorithms-keeper · 2022-10-26T14:48:26Z

+    0
+    """
+
+    def update_area_of_max_square_using_dp_array(


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array

kondekarshubham123 · 2022-10-26T14:50:37Z

Suggested small changes have been implemented,

Please review @cclauss , @CaedenPH

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-26T14:51:56Z

+    0
+    """
+
+    def update_area_of_max_square(row: int, col: int) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square

algorithms-keeper · 2022-10-26T14:51:56Z

+    0
+    """
+
+    def update_area_of_max_square_using_dp_array(


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array

cclauss · 2022-10-26T14:55:44Z

Is there a function missing doctests?

Click Details to the right of the ❌ below to see misspelled words and long lines (max 88 chars per line).

kondekarshubham123 · 2022-10-26T14:59:31Z

Actually the for recursive code, inside a parent function
I haven't added the doctest, do I need to add?

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-10-26T15:03:28Z

+    0
+    """
+
+    def update_area_of_max_square(row: int, col: int) -> int:


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square

algorithms-keeper · 2022-10-26T15:03:29Z

+    0
+    """
+
+    def update_area_of_max_square_using_dp_array(


As there is no test file in this pull request nor any test function or class in the file matrix/largest_square_area_in_matrix.py, please provide doctest for the function update_area_of_max_square_using_dp_array

cclauss · 2022-10-26T15:03:55Z

Cool. Doctests do not run in functions that are nested under other functions so we can ignore the keeperbot on that one.

kondekarshubham123 · 2022-10-26T15:04:42Z

@cclauss, Misspelled words and maxline error took in consideration and done necessary changes

Create largest_square_area_in_matrix.py

0966f4e

algorithms-keeper Bot added the require tests Tests [doctest/unittest/pytest] are required label Oct 26, 2022

algorithms-keeper Bot reviewed Oct 26, 2022

View reviewed changes

algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 26, 2022

[pre-commit.ci] auto fixes from pre-commit.com hooks

bab2890

for more information, see https://pre-commit.ci

algorithms-keeper Bot reviewed Oct 26, 2022

View reviewed changes

algorithms-keeper Bot mentioned this pull request Oct 26, 2022

Added new question on greedy algorithm concept #7675

Closed

14 tasks

CaedenPH reviewed Oct 26, 2022

View reviewed changes

Comment thread matrix/largest_square_area_in_matrix.py Outdated

Comment thread matrix/largest_square_area_in_matrix.py Outdated

Update matrix/largest_square_area_in_matrix.py

f3458d6

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

algorithms-keeper Bot reviewed Oct 26, 2022

View reviewed changes

Update matrix/largest_square_area_in_matrix.py

3a45fb7

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

algorithms-keeper Bot reviewed Oct 26, 2022

View reviewed changes

kondekarshubham123 requested a review from CaedenPH October 26, 2022 14:48

algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 26, 2022

[pre-commit.ci] auto fixes from pre-commit.com hooks

25f97af

for more information, see https://pre-commit.ci

algorithms-keeper Bot reviewed Oct 26, 2022

View reviewed changes

Update largest_square_area_in_matrix.py

f1ff187

algorithms-keeper Bot reviewed Oct 26, 2022

View reviewed changes

cclauss approved these changes Oct 26, 2022

View reviewed changes

algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2022

cclauss merged commit 5c8a939 into TheAlgorithms:master Oct 26, 2022

cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 26, 2022

Uh oh!

Uh oh!

Conversation

kondekarshubham123 commented Oct 26, 2022

Describe your change:

Checklist:

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

CaedenPH left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

kondekarshubham123 commented Oct 26, 2022

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 26, 2022

Choose a reason for hiding this comment