Add web program to fetch top 10 real time billionaires using the forbes API. by girisagar46 · Pull Request #7538 · TheAlgorithms/Python

girisagar46 · 2022-10-23T05:32:49Z

Describe your change:

Using the Forbes API to get the top ten real-time billionaires and present in a rich table.

Here's the sample output:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

web_programming/get_top_billioners.py

cclauss · 2022-10-23T06:46:04Z

I like this one. Instead of Tabulate, would you be willing to do the table in Rich instead?
I want to use Rich to do some other color-in-the-terminal things and would rather add just one import instead of two.

def display_billionaires(forbes_billionaires: dict) -> None:
    """
    Display Forbes real time billionaires in a rich table
    Args:
        forbes_billionaires (dict): Forbes top 10 real time billionaires
    """
    from rich.console import Console  # Move these imports to the top of the file.
    from rich.table import Table
    table = Table(title="Forbes Real Time Billionaires", style="green")
    for key in forbes_billionaires[0]:
        table.add_column(key)
    for billionaire in forbes_billionaires:
        table.add_row(*billionaire.values())
    Console().print(table)


if __name__ == "__main__":
    display_billionaires(get_forbes_real_time_billionaires())

CaedenPH · 2022-10-23T09:29:47Z

web_programming/get_top_billioners.py

+                "Age": today.year
+                - birthdate.year
+                - ((today.month, today.day) < (birthdate.month, birthdate.day)),


Suggested change

"Age": today.year

- birthdate.year

- ((today.month, today.day) < (birthdate.month, birthdate.day)),

"Age": (

today.year - birthdate.year -

((today.month, today.day) < (birthdate.month, birthdate.day))

),

I believe that psf/black will reformat this back to the original solution (terms on separate lines).

For rich, we may need to convert age to a str.

Thank you. This has been modified here: c85adac

CaedenPH · 2022-10-23T09:33:02Z

web_programming/get_top_billioners.py

+    Returns:
+    Top 10 realtime billionaires date in tabulated string.


Suggested change

Returns:

Top 10 realtime billionaires date in tabulated string.

Returns the Top 10 realtime billionaires date in tabulated string.

This is a comment syntax that some editors (PyCharm, I think) prefer so we should leave it as is.

Yeah, this was automatically done by PyCharm. However, I've modified it a bit. c85adac

girisagar46 · 2022-10-23T12:14:31Z

I like this one. Instead of Tabulate, would you be willing to do the table in Rich instead?

Thank you, @cclauss for reviewing it. Rich is awesome. I've modified it here: c85adac

CaedenPH

Small change

CaedenPH · 2022-10-23T12:20:00Z

web_programming/get_top_billioners.py

+from rich import box
+from rich import console as rich_console
+from rich import table as rich_table


Suggested change

from rich import box

from rich import console as rich_console

from rich import table as rich_table

from rich import (box, console as rich_console, table as rich_table)

isort sorts your imports so you don't have to. ;-)

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

for more information, see https://pre-commit.ci

CaedenPH · 2022-10-23T12:31:29Z

Oh, apparently the pre-commit automatically reverts it. No problem, @cclauss, can we get your review?

cclauss · 2022-10-23T12:33:29Z

It does not work on my Mac. I get json.decoder.JSONDecodeError: Expecting value: line 2 column 1 (char 1)

But if I go to the URL with my browser, it looks like all the right stuff.

cclauss · 2022-10-23T12:38:13Z

Does it work on your machine @CaedenPH ?

CaedenPH · 2022-10-23T12:42:02Z

Does it work on your machine @CaedenPH ?

I also get the JSONDecodeError. The url seems to return a valid json response though...

cclauss · 2022-10-23T12:48:10Z

Often we can solve these issues with fake_useragent but that did not fix it for me.

girisagar46 · 2022-10-23T12:53:03Z

Often we can solve these issues with fake_useragent but that did not fix it for me.

Oh!! That's weird. It's working as expected on my mac.
Can you try by passing headers = {'Accept': 'application/json'} on requests.get to increase the likelihood of receiving a JSON response. @cclauss

cclauss · 2022-10-23T12:58:12Z

headers = {'Accept': 'application/json'} did NOT fix it.

Do you have a Forbes login that you are using?

girisagar46 · 2022-10-23T13:11:35Z

Do you have a Forbes login that you are using?

No, I am not using it. Hitting the API in Incognito mode is giving me the correct response.
I've changed the API path to https://www.forbes.com/forbesapi/person/rtb/0/position/true.json in this commit e05ef42.
Can you try it again? @cclauss

CaedenPH · 2022-10-23T13:17:55Z

Do you have a Forbes login that you are using?

No, I am not using it. Hitting the API in Incognito mode is giving me the correct response. I've changed the API path to https://www.forbes.com/forbesapi/person/rtb/0/position/true.json in this commit e05ef42. Can you try it again? @cclauss

I can hit the api successfully when I visit the url manually, but requests automates this process, which triggers forbes's anti-bot protection software, blocking us.

cclauss · 2022-10-23T13:28:57Z

@dhruvmanila Any ideas on how to make this work? Should we use httpx instead of requests? Other ideas?

dhruvmanila · 2022-10-23T14:40:08Z

web_programming/get_top_billioners.py

+API_URL = (
+    "https://www.forbes.com/forbesapi/person/rtb/0/position/true.json"
+    "?fields=personName,gender,source,countryOfCitizenship,birthDate,finalWorth"
+    f"&limit={LIMIT}"
+)


requests can automatically encode the URL parameters: https://requests.readthedocs.io/en/latest/user/quickstart/#passing-parameters-in-urls. Please use this instead.

dhruvmanila · 2022-10-23T14:41:25Z

Oh, already merged. Also, checks are failing.

Add web program to fetch top 10 realtime billioners using forbes API.

e43c528

girisagar46 requested a review from cclauss as a code owner October 23, 2022 05:32

algorithms-keeper bot added enhancement This PR modified some existing files require type hints https://docs.python.org/3/library/typing.html labels Oct 23, 2022

algorithms-keeper bot reviewed Oct 23, 2022

View reviewed changes

web_programming/get_top_billioners.py Outdated Show resolved Hide resolved

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022

Provide return type to function.

e9baf8f

algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 23, 2022

CaedenPH reviewed Oct 23, 2022

View reviewed changes

girisagar46 added 2 commits October 23, 2022 21:06

Use rich for tables and minor refactors.

c85adac

Fix tiny typo.

b89040d

Add the top {LIMIT} in rich table title.

a4b2df8

girisagar46 requested review from CaedenPH and removed request for cclauss October 23, 2022 12:18

CaedenPH reviewed Oct 23, 2022

View reviewed changes

girisagar46 and others added 2 commits October 23, 2022 21:27

Update web_programming/get_top_billioners.py

ac5e839

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

cc8a460

for more information, see https://pre-commit.ci

cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 23, 2022

Change the API path.

e05ef42

Update get_top_billioners.py

05c8a6c

cclauss approved these changes Oct 23, 2022

View reviewed changes

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022

cclauss merged commit 0f06a0b into TheAlgorithms:master Oct 23, 2022

dhruvmanila reviewed Oct 23, 2022

View reviewed changes

		Returns:
		Top 10 realtime billionaires date in tabulated string.

Uh oh!

Conversation

girisagar46 commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

cclauss commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CaedenPH Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

girisagar46 commented Oct 23, 2022

Uh oh!

CaedenPH left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CaedenPH commented Oct 23, 2022

Uh oh!

cclauss commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Oct 23, 2022

Uh oh!

CaedenPH commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Oct 23, 2022

Uh oh!

girisagar46 commented Oct 23, 2022

Uh oh!

cclauss commented Oct 23, 2022

Uh oh!

girisagar46 commented Oct 23, 2022

Uh oh!

CaedenPH commented Oct 23, 2022

Uh oh!

cclauss commented Oct 23, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhruvmanila commented Oct 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

girisagar46 commented Oct 23, 2022 •

edited

Loading

cclauss commented Oct 23, 2022 •

edited

Loading

CaedenPH Oct 23, 2022 •

edited

Loading

cclauss commented Oct 23, 2022 •

edited

Loading

CaedenPH commented Oct 23, 2022 •

edited

Loading

dhruvmanila commented Oct 23, 2022 •

edited

Loading