add electric conductivity algorithm#7449
Merged
cclauss merged 9 commits intoTheAlgorithms:masterfrom Oct 29, 2022
sadiqebrahim:master
Merged
add electric conductivity algorithm#7449cclauss merged 9 commits intoTheAlgorithms:masterfrom sadiqebrahim:master
cclauss merged 9 commits intoTheAlgorithms:masterfrom
sadiqebrahim:master
Conversation
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
removed
the
tests are failing
CaedenPH
reviewed
Oct 20, 2022
electronics/electric_conductivity.py
Outdated
| "mobility", | ||
| conductivity / (electron_conc * ELECTRON_CHARGE), | ||
| ) | ||
| else: |
Contributor
There was a problem hiding this comment.
In what scenario is this else triggered?
electronics/electric_conductivity.py
Outdated
| """ | ||
| This function can calculate any one of the three - | ||
| 1. Conductivity | ||
| 2, Conductivity |
|
|
||
| def electric_conductivity( | ||
| conductivity: float, | ||
| electron_conc: float, |
Contributor
There was a problem hiding this comment.
What does conc stand for?
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
algorithms-keeper
bot
added
tests are failing
cclauss
approved these changes
Oct 29, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
added new algorithm for calculating electric conductivity
Checklist:
Fixes: #{$ISSUE_NO}.