Skip to content

Fix Horn-Schunck depreciated namespace#7390

Merged
cclauss merged 2 commits intoTheAlgorithms:masterfrom
tianyizheng02:horn-schunck
Oct 18, 2022
Merged

Fix Horn-Schunck depreciated namespace#7390
cclauss merged 2 commits intoTheAlgorithms:masterfrom
tianyizheng02:horn-schunck

Conversation

@tianyizheng02
Copy link
Copy Markdown
Contributor

@tianyizheng02 tianyizheng02 commented Oct 17, 2022 •
edited
Loading

Describe your change:

Updated the namespace of convolve in computer_vision/horn_schunck.py from scipy.ndimage.filters to scipy.ndimage, as the former is depreciated (see the release notes for SciPy release 1.8.0 for more details).

Fixes #7299

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@tianyizheng02
Copy link
Copy Markdown
Contributor Author

tianyizheng02 commented Oct 17, 2022

@CaedenPH @cclauss Could one of you take a look to see if this solves the issue and is good for merging?

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 18, 2022

Please provide us a url to the docs that discuss the deprecation.

@tianyizheng02
Copy link
Copy Markdown
Contributor Author

tianyizheng02 commented Oct 18, 2022 •
edited
Loading

@cclauss The release notes for SciPy 1.8.0 say the following:

In this release, all namespaces that were private but happened to miss underscores in their names have been deprecated. These include (as examples, there are many more):
- scipy.signal.spline
- scipy.ndimage.filters
...
All functions and other objects in these namespaces that were meant to be public are accessible from their respective public namespace

@cclauss cclauss merged commit 49cd46a into TheAlgorithms:master Oct 18, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PYTEST WARNING] Horn schunk

2 participants

@tianyizheng02 @cclauss