Skip to content

added support for inverse of 3x3 matrix#7355

Merged
cclauss merged 6 commits intoTheAlgorithms:masterfrom
kituuu:inverse_matrix
Oct 26, 2022
Merged

added support for inverse of 3x3 matrix#7355
cclauss merged 6 commits intoTheAlgorithms:masterfrom
kituuu:inverse_matrix

Conversation

@kituuu
Copy link
Copy Markdown
Contributor

@kituuu kituuu commented Oct 17, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [] All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 17, 2022
cclauss
cclauss reviewed Oct 20, 2022
View reviewed changes
matrix/inverse_of_matrix.py Outdated
Comment on lines +35 to +63
...
ValueError: This matrix has no inverse.

More examples:

>>> inverse_of_matrix([])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.

>>> inverse_of_matrix([[],[]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.

>>> inverse_of_matrix([[1, 2], [3, 4], [5, 6]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.

>>> inverse_of_matrix([[1, 2, 1], [0,3, 4]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.

>>> inverse_of_matrix([[1, 2, 3], [7, 8, 9], [7, 8, 9]])
Traceback (most recent call last):
...
ValueError: This matrix has no inverse.
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test that all lines between Traceback and the Error are indented by at least four spaces.

Suggested change
...
ValueError: This matrix has no inverse.
More examples:
>>> inverse_of_matrix([])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[],[]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[1, 2], [3, 4], [5, 6]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[1, 2, 1], [0,3, 4]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[1, 2, 3], [7, 8, 9], [7, 8, 9]])
Traceback (most recent call last):
...
ValueError: This matrix has no inverse.
...
ValueError: This matrix has no inverse.
>>> inverse_of_matrix([])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[],[]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[1, 2], [3, 4], [5, 6]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[1, 2, 1], [0,3, 4]])
Traceback (most recent call last):
...
ValueError: Please provide a matrix of size 2x2 or 3x3.
>>> inverse_of_matrix([[1, 2, 3], [7, 8, 9], [7, 8, 9]])
Traceback (most recent call last):
...
ValueError: This matrix has no inverse.

cclauss
cclauss reviewed Oct 20, 2022
View reviewed changes
matrix/inverse_of_matrix.py Outdated
Comment on lines +144 to +151
adjoint_matrix = [
[d(0.0), d(0.0), d(0.0)],
[d(0.0), d(0.0), d(0.0)],
[d(0.0), d(0.0), d(0.0)],
]
for i in range(3):
for j in range(3):
adjoint_matrix[i][j] = cofactor_matrix[j][i]
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
adjoint_matrix = [
[d(0.0), d(0.0), d(0.0)],
[d(0.0), d(0.0), d(0.0)],
[d(0.0), d(0.0), d(0.0)],
]
for i in range(3):
for j in range(3):
adjoint_matrix[i][j] = cofactor_matrix[j][i]
adjoint_matrix = zip(*cofactor_matrix)

https://www.geeksforgeeks.org/transpose-matrix-single-line-python

Copy link
Copy Markdown
Contributor Author

@kituuu kituuu Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sir.

cclauss
cclauss reviewed Oct 20, 2022
View reviewed changes
matrix/inverse_of_matrix.py Outdated
and len(matrix[2]) == 3
):
# Calculate the determinant of the matrix using Sarrus rule
determinant = (
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
determinant = (
determinant = float(

Copy link
Copy Markdown
Contributor Author

@kituuu kituuu Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on it sir.

cclauss
cclauss reviewed Oct 20, 2022
View reviewed changes
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 22, 2022
@kituuu
Copy link
Copy Markdown
Contributor Author

kituuu commented Oct 22, 2022 •
edited
Loading

@cclauss Sir, the zip() method involves a list of tuples. And in my code, every matrix was a list of lists. So I used NumPy.array instead of zip. Also, I don't know what error doctest is giving, can u help me with that?
Edit : Now fixed (But I don't know how xD)

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 22, 2022
@kituuu kituuu mentioned this pull request Oct 23, 2022
Merged
13 tasks
@kituuu
Copy link
Copy Markdown
Contributor Author

kituuu commented Oct 26, 2022

@poyea @cclauss @dhruvmanila Sir, please review this also. And suggest changes if required. 🥲

chriso345
chriso345 reviewed Oct 26, 2022
View reviewed changes
CaedenPH
CaedenPH reviewed Oct 26, 2022
View reviewed changes
@cclauss @CaedenPH @chriso345
Apply all suggestions from code review
81658e1 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
cclauss
cclauss approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied all code review suggestions.

Thanks for your persistence!!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2022
@cclauss cclauss merged commit 9390565 into TheAlgorithms:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPH CaedenPH CaedenPH left review comments

@chriso345 chriso345 chriso345 left review comments

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kituuu @cclauss @CaedenPH @chriso345