Skip to content

types: Update binary search tree typehints - #7197

Merged
cclauss merged 4 commits into
TheAlgorithms:masterfrom
CaedenPH:binary-search-tree-fixes
Oct 15, 2022
Merged

types: Update binary search tree typehints#7197
cclauss merged 4 commits into
TheAlgorithms:masterfrom
CaedenPH:binary-search-tree-fixes

Conversation

@CaedenPH

@CaedenPH CaedenPH commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

Update the typehints in data_structures/binary_tree/binary_tree_search.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 14, 2022
dhruvmanila
dhruvmanila requested changes Oct 15, 2022
View reviewed changes
Comment thread data_structures/binary_tree/binary_search_tree.py Outdated
Comment thread data_structures/binary_tree/binary_search_tree.py Outdated
@algorithms-keeper algorithms-keeper Bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 15, 2022
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 15, 2022
@CaedenPH
CaedenPH requested a review from dhruvmanila October 15, 2022 12:05
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 15, 2022
dhruvmanila
dhruvmanila requested changes Oct 15, 2022
View reviewed changes
Comment thread data_structures/binary_tree/binary_search_tree.py
dhruvmanila
dhruvmanila requested changes Oct 15, 2022
View reviewed changes
Comment thread data_structures/binary_tree/binary_search_tree.py Outdated
Comment thread data_structures/binary_tree/binary_search_tree.py Outdated
@CaedenPH

CaedenPH commented Oct 15, 2022

Copy link
Copy Markdown
Contributor Author

@cclauss Do you have any additional comments?

@cclauss

cclauss commented Oct 15, 2022

Copy link
Copy Markdown
Member

if @dhruvmanila is satisfied then that is all that is required to merge.

@cclauss
cclauss merged commit c94e215 into TheAlgorithms:master Oct 15, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2022
@CaedenPH
CaedenPH deleted the binary-search-tree-fixes branch October 15, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaedenPH @cclauss @dhruvmanila