Skip to content

shorten code using max function - #7190

Closed
Luk-ESC wants to merge 1 commit into
TheAlgorithms:masterfrom
Luk-ESC:patch-3
Closed

shorten code using max function#7190
Luk-ESC wants to merge 1 commit into
TheAlgorithms:masterfrom
Luk-ESC:patch-3

Conversation

@Luk-ESC

@Luk-ESC Luk-ESC commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

replaced the for loop with a call to max() using the key argument

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Luk-ESC
shorten code using max function
e79b13b 
replaced the for loop with a call to max() using the key argument
@Luk-ESC
Luk-ESC requested a review from Kush1101 as a code owner October 14, 2022 19:10
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 14, 2022
@algorithms-keeper algorithms-keeper Bot mentioned this pull request Oct 14, 2022
Closed
14 tasks
@cclauss

cclauss commented Oct 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

As discussed in CONTRIBUTING.md, the goal of many algorithms in this repo is to show how an algorithm is created. Removing 5 lines of code by using a builtin function can kinda defeat that purpose.

@cclauss cclauss closed this Oct 14, 2022
@cclauss cclauss mentioned this pull request Oct 15, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Luk-ESC @cclauss