Skip to content

README.md: Lose LGTM badge because we don't use it - #7063

Merged
poyea merged 2 commits into
masterfrom
README.md-Lose-LGTM-badge-because-we-don't-use-it
Oct 12, 2022
Merged

README.md: Lose LGTM badge because we don't use it#7063
poyea merged 2 commits into
masterfrom
README.md-Lose-LGTM-badge-because-we-don't-use-it

Conversation

@cclauss

@cclauss cclauss commented Oct 12, 2022

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Oct 12, 2022
@cclauss cclauss removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2022
@cclauss
cclauss requested review from dhruvmanila and poyea October 12, 2022 18:46
@poyea
poyea merged commit bae08ad into master Oct 12, 2022
@poyea
poyea deleted the README.md-Lose-LGTM-badge-because-we-don't-use-it branch October 12, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

documentation This PR modified documentation files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @poyea