Add typing to data_structures/heap/heap_generic.py#7044
Merged
cclauss merged 8 commits intoTheAlgorithms:masterfrom Oct 12, 2022
Merged
Add typing to data_structures/heap/heap_generic.py#7044cclauss merged 8 commits intoTheAlgorithms:masterfrom
cclauss merged 8 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
enhancement
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 12, 2022
Comment on lines
+12
to
+14
| self.arr: list = list() | ||
| # Stores indexes of each item for supporting updates and deletion. | ||
| self.pos_map = {} | ||
| self.pos_map: dict = {} |
Member
There was a problem hiding this comment.
These are really not needed. Both Python and mypy are able to figure this out without hinting.
Contributor
Author
There was a problem hiding this comment.
i got an error in pipeline without adding this: https://results.pre-commit.ci/run/github/63476337/1665575464.hZt5fgARRZacJLt5kikIdg @cclauss
Contributor
Author
There was a problem hiding this comment.
@cclauss if you are satisfied, can you please approve? i cannot open more PRs in the project since i have mutliple open - #7043 (comment)
Contributor
Author
|
requesting review if someone can please take a look. thanks in advance! |
cclauss
changed the title
cclauss
approved these changes
Oct 12, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
Contributor
Author
|
@cclauss can you please add hacktoberfest-accepted label? |
cclauss
added
hacktoberfest
hacktoberfest-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.