Skip to content

Add typing to aho_corasick.py#7041

Closed
saksham-chawla wants to merge 1 commit intoTheAlgorithms:masterfrom
saksham-chawla:patch-4
Closed

Add typing to aho_corasick.py#7041
saksham-chawla wants to merge 1 commit intoTheAlgorithms:masterfrom
saksham-chawla:patch-4

Conversation

@saksham-chawla
Copy link
Copy Markdown
Contributor

@saksham-chawla saksham-chawla commented Oct 12, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 12, 2022
@saksham-chawla saksham-chawla changed the title Update aho_corasick.py Add typing to aho_corasick.py Oct 12, 2022
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 12, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saksham-chawla