Skip to content

Add typing to data_structures/hashing/hash_table.py#7040

Merged
cclauss merged 4 commits intoTheAlgorithms:masterfrom
saksham-chawla:patch-3
Oct 12, 2022
Merged

Add typing to data_structures/hashing/hash_table.py#7040
cclauss merged 4 commits intoTheAlgorithms:masterfrom
saksham-chawla:patch-3

Conversation

@saksham-chawla
Copy link
Copy Markdown
Contributor

@saksham-chawla saksham-chawla commented Oct 12, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 12, 2022
@saksham-chawla saksham-chawla changed the title Update hash_table.py Add typing Oct 12, 2022
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 12, 2022
Closed
14 tasks
cclauss
cclauss reviewed Oct 12, 2022
View reviewed changes
data_structures/hashing/hash_table.py
Comment on lines +13 to +14
charge_factor: int | None = None,
lim_charge: float | None = None,
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python and mypy can figure this out and it is a suggestion to the caller to pass in an int and not pass in None.

Suggested change
charge_factor: int | None = None,
lim_charge: float | None = None,
charge_factor: int = None,
lim_charge: float = None,

Copy link
Copy Markdown
Contributor Author

@saksham-chawla saksham-chawla Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, but code legibility changes, since it's optional.

Copy link
Copy Markdown
Contributor Author

@saksham-chawla saksham-chawla Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss if you have a strong opinion, i can change - but personally this looks more legible is all. :)

@saksham-chawla
Copy link
Copy Markdown
Contributor Author

saksham-chawla commented Oct 12, 2022

requesting review if someone can please take a look. thanks in advance!

@cclauss cclauss changed the title Add typing Add typing to data_structures/hashing/hash_table.py Oct 12, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2022
@cclauss cclauss merged commit aeb933b into TheAlgorithms:master Oct 12, 2022
@saksham-chawla
Copy link
Copy Markdown
Contributor Author

saksham-chawla commented Oct 12, 2022

@cclauss can you please add hacktoberfest-accepted label?

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saksham-chawla @cclauss