Conversation
made necessary changes!
for more information, see https://pre-commit.ci
added necessary changes!
for more information, see https://pre-commit.ci
added the necessary changes!
for more information, see https://pre-commit.ci
added necessary changes!
added necessary changes
added longest_valid_parenthesis.py
for more information, see https://pre-commit.ci
added longest_valid_parenthesis.py
for more information, see https://pre-commit.ci
added longest_valid_parenthesis.py
added longest_valid_parenthesis.py
added longest_valid_parenthesis.py
added sleepsort.py
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| for i in range(0,n): | ||
| a = int(input()) | ||
| items.append(a) | ||
| def sleep_sort(i): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleepsort.py, please provide doctest for the function sleep_sort
Please provide return type hint for the function: sleep_sort. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: i
Please provide descriptive name for the parameter: i
| @@ -0,0 +1,34 @@ | |||
| def longest_valid_parenthesis(s: str) -> int: | |||
There was a problem hiding this comment.
Please provide descriptive name for the parameter: s
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| items.append(a) | ||
|
|
||
|
|
||
| def sleep_sort(i): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file sorts/sleepsort.py, please provide doctest for the function sleep_sort
Please provide return type hint for the function: sleep_sort. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: i
Please provide descriptive name for the parameter: i
| @@ -0,0 +1,34 @@ | |||
| def longest_valid_parenthesis(s: str) -> int: | |||
There was a problem hiding this comment.
Please provide descriptive name for the parameter: s
2 participants
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.